Skip to content

Enforce model element EnabledBy in the .messages.in files #47064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Enforce model element EnabledBy in the .messages.in files #47064

wants to merge 1 commit into from

Conversation

gavin-apple
Copy link
Contributor

@gavin-apple gavin-apple commented Jun 23, 2025 •
edited by webkit-early-warning-system
Loading

3e0d1c4

Enforce model element EnabledBy in the .messages.in files
https://bugs.webkit.org/show_bug.cgi?id=294844
rdar://problem/154096315

Reviewed by NOBODY (OOPS!).

Enforce enablement of IPC for model process using the EnabledBy
format within the .messages.in files. Also cleans up our
ModelProcessConnectionParameters creation as the UI process already
has all of the necessary state.

* Source/WebKit/ModelProcess/ModelProcess.messages.in:
* Source/WebKit/UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::createModelProcessConnection):
* Source/WebKit/UIProcess/WebProcessProxy.h:
* Source/WebKit/UIProcess/WebProcessProxy.messages.in:
* Source/WebKit/WebProcess/Model/ModelProcessConnection.cpp:
(WebKit::ModelProcessConnection::create):
(WebKit::getModelProcessConnectionParameters): Deleted.
* Source/WebKit/WebProcess/Model/ModelProcessConnection.messages.in:
* Source/WebKit/WebProcess/Model/ModelProcessModelPlayer.messages.in:

3e0d1c4

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ⏳ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@gavin-apple gavin-apple requested a review from cdumez as a code owner June 23, 2025 15:31
@gavin-apple gavin-apple self-assigned this Jun 23, 2025
@gavin-apple gavin-apple added the New Bugs Unclassified bugs are placed in this component until the correct component can be determined. label Jun 23, 2025
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jun 23, 2025 •
edited
Loading

EWS run on previous version of this PR (hash d7f3c4a)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style   🛠 ios   🛠 mac ❌ 🛠 wpe ⏳ 🛠 win
  🛠 ios-sim   🛠 mac-AS-debug ❌ 🧪 wpe-wk2 ⏳ 🧪 win-tests
✅ 🧪 webkitperl   🧪 ios-wk2   🧪 api-mac ❌ 🧪 api-wpe
  🧪 ios-wk2-wpt   🧪 mac-wk1 ❌ 🛠 wpe-cairo
  🧪 api-ios   🧪 mac-wk2 ❌ 🛠 gtk
  🛠 vision   🧪 mac-AS-debug-wk2 ❌ 🧪 gtk-wk2
  🛠 vision-sim   🧪 mac-wk2-stress ❌ 🧪 api-gtk
⏳ 🧪 vision-wk2   🧪 mac-intel-wk2 ⏳ 🛠 playstation
  🛠 tv ❌ 🛠 mac-safer-cpp
  🛠 tv-sim
⏳ 🛠 watch
❌ 🛠 watch-sim

@gavin-apple gavin-apple marked this pull request as draft June 23, 2025 15:33
@gavin-apple gavin-apple force-pushed the eng/Enforce-model-element-EnabledBy-in-the-messages-in-files branch from d7f3c4a to 9c8a220 Compare June 23, 2025 15:40
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jun 23, 2025 •
edited
Loading

EWS run on previous version of this PR (hash 9c8a220)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ⏳ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@gavin-apple gavin-apple requested a review from achan00 June 23, 2025 17:36
@gavin-apple
Enforce model element EnabledBy in the .messages.in files
3e0d1c4 
https://bugs.webkit.org/show_bug.cgi?id=294844
rdar://problem/154096315

Reviewed by NOBODY (OOPS!).

Enforce enablement of IPC for model process using the EnabledBy
format within the .messages.in files. Also cleans up our
ModelProcessConnectionParameters creation as the UI process already
has all of the necessary state.

* Source/WebKit/ModelProcess/ModelProcess.messages.in:
* Source/WebKit/UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::createModelProcessConnection):
* Source/WebKit/UIProcess/WebProcessProxy.h:
* Source/WebKit/UIProcess/WebProcessProxy.messages.in:
* Source/WebKit/WebProcess/Model/ModelProcessConnection.cpp:
(WebKit::ModelProcessConnection::create):
(WebKit::getModelProcessConnectionParameters): Deleted.
* Source/WebKit/WebProcess/Model/ModelProcessConnection.messages.in:
* Source/WebKit/WebProcess/Model/ModelProcessModelPlayer.messages.in:
@gavin-apple gavin-apple force-pushed the eng/Enforce-model-element-EnabledBy-in-the-messages-in-files branch from 9c8a220 to 3e0d1c4 Compare June 30, 2025 14:14
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jun 30, 2025 •
edited
Loading

EWS run on current version of this PR (hash 3e0d1c4)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ⏳ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdumez cdumez Awaiting requested review from cdumez cdumez is a code owner

@achan00 achan00 Awaiting requested review from achan00

Assignees

@gavin-apple gavin-apple

Labels
New Bugs Unclassified bugs are placed in this component until the correct component can be determined.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gavin-apple @webkit-early-warning-system