Skip to content

[LibWebRTC] Unreviewed, update CMake sources after 296434@main #47062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 24, 2025
Merged

[LibWebRTC] Unreviewed, update CMake sources after 296434@main #47062

merged 1 commit into from
Jun 24, 2025
+974 −958

Conversation

dpino
Copy link
Contributor

@dpino dpino commented Jun 23, 2025 •
edited by webkit-early-warning-system
Loading

82f2bfb

[LibWebRTC] Unreviewed, update CMake sources after 296434@main
https://bugs.webkit.org/show_bug.cgi?id=294606

Changeset 296434@main upgraded boringssl to M138. After this change,
LibWebTC's CMake sources should also be upgraded.

* Source/ThirdParty/libwebrtc/CMakeLists.txt:
* Source/ThirdParty/libwebrtc/Source/third_party/boringssl/err_data.cc: Renamed from Source/ThirdParty/libwebrtc/Source/third_party/boringssl/err_data.c.

Canonical link: https://commits.webkit.org/296549@main

051be6d

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe   🛠 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2   🧪 win-tests
✅ 🧪 webkitperl   🧪 ios-wk2   🧪 api-mac   🧪 api-wpe
  🧪 ios-wk2-wpt   🧪 mac-wk1   🛠 wpe-cairo
  🧪 api-ios   🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision   🧪 mac-AS-debug-wk2   🧪 gtk-wk2
✅ 🛠 vision-sim   🧪 mac-wk2-stress   🧪 api-gtk
  🧪 vision-wk2   🧪 mac-intel-wk2   🛠 playstation
✅ 🛠 🧪 unsafe-merge ✅ 🛠 tv
  🛠 tv-sim
  🛠 watch
✅ 🛠 watch-sim

@dpino dpino self-assigned this Jun 23, 2025
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jun 23, 2025 •
edited
Loading

EWS run on previous version of this PR (hash 97e8747)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🛠 ios-sim loading 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ⏳ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 tv
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@dpino dpino marked this pull request as draft June 23, 2025 15:00
@dpino
Copy link
Contributor Author

dpino commented Jun 23, 2025

After these changes, I am getting many link errors on Linux:

FAILED: lib/libWPEWebKit-2.0.so.1.6.1
: && /usr/bin/clang++-20 -fPIC -fdiagnostics-color=always -fcolor-diagnostics -Wextra -Wall -Werror=undefined-internal -Werror=undefined-inline -pipe -Wno-noexcept-type -Wno-psabi -Wno-misleading-indentation -Wno-parentheses-equality -Qunused-arguments -Wundef -Wpointer-arith -Wmissing-format-attri
/usr/bin/ld: lib/libwebrtc.a(openssl_key_pair.cc.o): in function `rtc::OpenSSLKeyPair::PublicKeyToPEMString[abi:cxx11]() const':
openssl_key_pair.cc:(.text._ZNK3rtc14OpenSSLKeyPair20PublicKeyToPEMStringB5cxx11Ev+0x30): undefined reference to `PEM_write_bio_PUBKEY'
/usr/bin/ld: lib/libwebrtc.a(a_time.cc.o): in function `ASN1_TIME_set':
a_time.cc:(.text.ASN1_TIME_set+0x48): undefined reference to `ASN1_GENERALIZEDTIME_adj'
/usr/bin/ld: a_time.cc:(.text.ASN1_TIME_set+0x94): undefined reference to `ASN1_UTCTIME_adj'
/usr/bin/ld: lib/libwebrtc.a(a_time.cc.o): in function `ASN1_TIME_diff':
a_time.cc:(.text.ASN1_TIME_diff+0x44): undefined reference to `asn1_utctime_to_tm'
/usr/bin/ld: a_time.cc:(.text.ASN1_TIME_diff+0x78): undefined reference to `asn1_generalizedtime_to_tm'
/usr/bin/ld: a_time.cc:(.text.ASN1_TIME_diff+0xa4): undefined reference to `asn1_utctime_to_tm'
/usr/bin/ld: a_time.cc:(.text.ASN1_TIME_diff+0x124): undefined reference to `asn1_generalizedtime_to_tm'
/usr/bin/ld: lib/libwebrtc.a(a_time.cc.o): in function `ASN1_TIME_to_posix':
a_time.cc:(.text.ASN1_TIME_to_posix+0x3c): undefined reference to `asn1_utctime_to_tm'
/usr/bin/ld: a_time.cc:(.text.ASN1_TIME_to_posix+0x78): undefined reference to `asn1_generalizedtime_to_tm'
/usr/bin/ld: lib/libwebrtc.a(tasn_dec.cc.o): in function `ASN1_item_d2i':
tasn_dec.cc:(.text.ASN1_item_d2i+0x4c): undefined reference to `ASN1_item_ex_free'
/usr/bin/ld: tasn_dec.cc:(.text.ASN1_item_d2i+0x70): undefined reference to `ASN1_item_ex_free'
/usr/bin/ld: lib/libwebrtc.a(tasn_dec.cc.o): in function `asn1_item_ex_d2i(ASN1_VALUE_st**, unsigned char const**, long, ASN1_ITEM_st const*, int, int, char, crypto_buffer_st*, int)':
tasn_dec.cc:(.text._ZL16asn1_item_ex_d2iPP13ASN1_VALUE_stPPKhlPK12ASN1_ITEM_stiicP16crypto_buffer_sti+0x6c): undefined reference to `ASN1_item_ex_free'
/usr/bin/ld: tasn_dec.cc:(.text._ZL16asn1_item_ex_d2iPP13ASN1_VALUE_stPPKhlPK12ASN1_ITEM_stiicP16crypto_buffer_sti+0x430): undefined reference to `ASN1_template_free'
/usr/bin/ld: tasn_dec.cc:(.text._ZL16asn1_item_ex_d2iPP13ASN1_VALUE_stPPKhlPK12ASN1_ITEM_stiicP16crypto_buffer_sti+0x550): undefined reference to `ASN1_item_ex_free'
/usr/bin/ld: tasn_dec.cc:(.text._ZL16asn1_item_ex_d2iPP13ASN1_VALUE_stPPKhlPK12ASN1_ITEM_stiicP16crypto_buffer_sti+0x618): undefined reference to `ASN1_template_free'
/usr/bin/ld: tasn_dec.cc:(.text._ZL16asn1_item_ex_d2iPP13ASN1_VALUE_stPPKhlPK12ASN1_ITEM_stiicP16crypto_buffer_sti+0x644): undefined reference to `ASN1_template_free'
/usr/bin/ld: tasn_dec.cc:(.text._ZL16asn1_item_ex_d2iPP13ASN1_VALUE_stPPKhlPK12ASN1_ITEM_stiicP16crypto_buffer_sti+0x79c): undefined reference to `ASN1_template_free'
/usr/bin/ld: tasn_dec.cc:(.text._ZL16asn1_item_ex_d2iPP13ASN1_VALUE_stPPKhlPK12ASN1_ITEM_stiicP16crypto_buffer_sti+0x864): undefined reference to `ASN1_item_ex_free'
/usr/bin/ld: tasn_dec.cc:(.text._ZL16asn1_item_ex_d2iPP13ASN1_VALUE_stPPKhlPK12ASN1_ITEM_stiicP16crypto_buffer_sti+0x8b0): undefined reference to `ASN1_item_ex_free'
/usr/bin/ld: lib/libwebrtc.a(tasn_dec.cc.o): in function `asn1_template_ex_d2i(ASN1_VALUE_st**, unsigned char const**, long, ASN1_TEMPLATE_st const*, char, crypto_buffer_st*, int)':
tasn_dec.cc:(.text._ZL20asn1_template_ex_d2iPP13ASN1_VALUE_stPPKhlPK16ASN1_TEMPLATE_stcP16crypto_buffer_sti+0x1d0): undefined reference to `ASN1_template_free'
/usr/bin/ld: lib/libwebrtc.a(tasn_dec.cc.o): in function `asn1_d2i_ex_primitive(ASN1_VALUE_st**, unsigned char const**, long, ASN1_ITEM_st const*, int, int, char)':
tasn_dec.cc:(.text._ZL21asn1_d2i_ex_primitivePP13ASN1_VALUE_stPPKhlPK12ASN1_ITEM_stiic+0x22c): undefined reference to `ASN1_TYPE_new'
/usr/bin/ld: tasn_dec.cc:(.text._ZL21asn1_d2i_ex_primitivePP13ASN1_VALUE_stPPKhlPK12ASN1_ITEM_stiic+0x60c): undefined reference to `ASN1_TYPE_free'
/usr/bin/ld: tasn_dec.cc:(.text._ZL21asn1_d2i_ex_primitivePP13ASN1_VALUE_stPPKhlPK12ASN1_ITEM_stiic+0x6fc): undefined reference to `ASN1_TYPE_free'
/usr/bin/ld: lib/libwebrtc.a(tasn_dec.cc.o): in function `asn1_template_noexp_d2i(ASN1_VALUE_st**, unsigned char const**, long, ASN1_TEMPLATE_st const*, char, crypto_buffer_st*, int)':
tasn_dec.cc:(.text._ZL23asn1_template_noexp_d2iPP13ASN1_VALUE_stPPKhlPK16ASN1_TEMPLATE_stcP16crypto_buffer_sti+0x134): undefined reference to `ASN1_item_ex_free'
/usr/bin/ld: tasn_dec.cc:(.text._ZL23asn1_template_noexp_d2iPP13ASN1_VALUE_stPPKhlPK16ASN1_TEMPLATE_stcP16crypto_buffer_sti+0x298): undefined reference to `ASN1_template_free'
/usr/bin/ld: tasn_dec.cc:(.text._ZL23asn1_template_noexp_d2iPP13ASN1_VALUE_stPPKhlPK16ASN1_TEMPLATE_stcP16crypto_buffer_sti+0x2c4): undefined reference to `ASN1_item_ex_free'
/usr/bin/ld: lib/libwebrtc.a(tasn_new.cc.o): in function `ASN1_item_ex_new':
...

@dpino dpino requested a review from philn June 23, 2025 15:05
@dpino dpino force-pushed the follow-up/296434@main branch from 97e8747 to a870cfc Compare June 24, 2025 03:15
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jun 24, 2025 •
edited
Loading

EWS run on previous version of this PR (hash a870cfc)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ⏳ 🛠 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2 ⏳ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🧪 api-ios   🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision   🧪 mac-AS-debug-wk2   🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ⏳ 🛠 playstation
  🛠 🧪 unsafe-merge ✅ 🛠 tv
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@dpino dpino marked this pull request as ready for review June 24, 2025 03:27
@dpino dpino added unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing and removed unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing labels Jun 24, 2025
@dpino dpino force-pushed the follow-up/296434@main branch from a870cfc to 051be6d Compare June 24, 2025 04:04
@dpino dpino added the WebRTC For bugs in WebRTC label Jun 24, 2025
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jun 24, 2025 •
edited
Loading

EWS run on current version of this PR (hash 051be6d)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe   🛠 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2   🧪 win-tests
✅ 🧪 webkitperl   🧪 ios-wk2   🧪 api-mac   🧪 api-wpe
  🧪 ios-wk2-wpt   🧪 mac-wk1   🛠 wpe-cairo
  🧪 api-ios   🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision   🧪 mac-AS-debug-wk2   🧪 gtk-wk2
✅ 🛠 vision-sim   🧪 mac-wk2-stress   🧪 api-gtk
  🧪 vision-wk2   🧪 mac-intel-wk2   🛠 playstation
✅ 🛠 🧪 unsafe-merge ✅ 🛠 tv
  🛠 tv-sim
  🛠 watch
✅ 🛠 watch-sim

@dpino dpino added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jun 24, 2025
@dpino
[LibWebRTC] Unreviewed, update CMake sources after 296434@main
82f2bfb 
https://bugs.webkit.org/show_bug.cgi?id=294606

Changeset 296434@main upgraded boringssl to M138. After this change,
LibWebTC's CMake sources should also be upgraded.

* Source/ThirdParty/libwebrtc/CMakeLists.txt:
* Source/ThirdParty/libwebrtc/Source/third_party/boringssl/err_data.cc: Renamed from Source/ThirdParty/libwebrtc/Source/third_party/boringssl/err_data.c.

Canonical link: https://commits.webkit.org/296549@main
@webkit-commit-queue
Copy link
Collaborator

Committed 296549@main (82f2bfb): https://commits.webkit.org/296549@main

Reviewed commits have been landed. Closing PR #47062 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 82f2bfb into WebKit:main Jun 24, 2025
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jun 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philn philn Awaiting requested review from philn

Assignees

@dpino dpino

Labels
WebRTC For bugs in WebRTC
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dpino @webkit-early-warning-system @webkit-commit-queue