Skip to content

Sync css/css-transforms from WPT upstream #47055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Ahmad-S792
Copy link
Contributor

@Ahmad-S792 Ahmad-S792 commented Jun 23, 2025

e25d351

Sync `css/css-transforms` from WPT upstream

https://bugs.webkit.org/show_bug.cgi?id=294837
rdar://154088766

Reviewed by Tim Nguyen.

Upstream commit: web-platform-tests/wpt@a572d07

* LayoutTests/imported/w3c/resources/resource-files.json:
* LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/animation/rotate-transform-equivalent.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/backface-visibility-001.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/backface-visibility-hidden-001.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/group/svg-transform-group-009.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/group/svg-transform-nested-009.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/group/svg-transform-nested-014.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/group/svg-transform-nested-019.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/individual-transform/w3c-import.log:
* LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/parsing/transform-valid-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/parsing/transform-valid.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/perspective-transforms-equivalence.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/preserve3d-and-flattening-001.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/skewX/svg-skewxy-001.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/skewY/svg-skewy-001.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/skewY/svg-skewy-006.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/skewY/svg-skewy-011.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/skewY/svg-skewy-016.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/skewY/svg-skewy-021.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/transform-box/w3c-import.log:
* LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/transform-compound-001-expected.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/transform-compound-001.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/transform-compound-ref.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/transform-input-005.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/transform-percent-008.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/transform3d-sorting-006.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/w3c-import.log:
* LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/3d-point-mapping-2-transforminterop-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/3d-point-mapping-2-transforminterop.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/3d-point-mapping-3-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/3d-point-mapping-3.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/3d-point-mapping-coplanar-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/3d-point-mapping-coplanar.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/3d-point-mapping-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/3d-point-mapping-overlapping-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/3d-point-mapping-overlapping.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/3d-point-mapping.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/css-scale-of-clip-path-expected.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/css-scale-of-clip-path-ref.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/css-scale-of-clip-path.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/individual-transform/individual-transform-3-expected.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/individual-transform/individual-transform-3.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/individual-transform/stacking-context-002-expected.xht
* LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/individual-transform/stacking-context-002.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/individual-transform/stacking-context-003-expected.xht
* LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/individual-transform/stacking-context-003.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/individual-transform/stacking-context-004-expected.xht
* LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/individual-transform/stacking-context-004.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/preserve3d-backface-hit-test-1-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/preserve3d-backface-hit-test-1.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/preserve3d-backface-hit-test-2-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/preserve3d-backface-hit-test-2.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/scale-animation-with-var-001-expected.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/scale-animation-with-var-001.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/scale-transform-filtered-text-expected.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/scale-transform-filtered-text-ref.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/scale-transform-filtered-text.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/transform-box/WEB_FEATURES.yml:
* LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/transform-matrix-009-expected.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/transform-matrix-009.html:

> Platform Specific Expectations:
* LayoutTests/platform/glib/TestExpectations:
* LayoutTests/platform/mac-wk1/TestExpectations:
* LayoutTests/platform/wpe/TestExpectations:

Canonical link: https://commits.webkit.org/296648@main

fe5f3e3

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ⏳ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 🛠 playstation
✅ 🛠 tv
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@Ahmad-S792 Ahmad-S792 self-assigned this Jun 23, 2025
@Ahmad-S792 Ahmad-S792 added the CSS Cascading Style Sheets implementation label Jun 23, 2025
@Ahmad-S792 Ahmad-S792 force-pushed the eng/Sync-css-css-transforms-from-WPT-upstream branch from e4cd649 to b5f5d14 Compare June 23, 2025 13:32
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jun 23, 2025
<meta name="fuzzy" content="maxDifference=0-178;totalPixels=0-538">
<meta name="fuzzy" content="maxDifference=0-94;totalPixels=0-538">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This undoes this unexported change: 49ef300 from @nikolaszimmermann

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will undo it. :-) Plus add any other test expectations in next commit.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nt1m - indeed, it is unfortunate. I should have exported this to WPT?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, unfortunarely there's no auto-export in WebKit, you have to go through the export-w3c-test-changes script, this command should do it:

export-w3c-test-changes -b 290800 -g 49ef3002488aa8b83b2f1975816d4172863f1554 -c

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, I did not know about the script, did it manually last time I had to do it. That's going to simplify a lot 👌

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahmad exported them here: web-platform-tests/wpt#53370

@Ahmad-S792 Ahmad-S792 removed the merging-blocked Applied to prevent a change from being merged label Jun 24, 2025
@Ahmad-S792 Ahmad-S792 force-pushed the eng/Sync-css-css-transforms-from-WPT-upstream branch from b5f5d14 to d53e6b9 Compare June 24, 2025 22:01
@Ahmad-S792 Ahmad-S792 force-pushed the eng/Sync-css-css-transforms-from-WPT-upstream branch from d53e6b9 to d42c24d Compare June 24, 2025 22:08
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jun 25, 2025
@Ahmad-S792 Ahmad-S792 removed the merging-blocked Applied to prevent a change from being merged label Jun 26, 2025
@Ahmad-S792 Ahmad-S792 force-pushed the eng/Sync-css-css-transforms-from-WPT-upstream branch from d42c24d to fe5f3e3 Compare June 26, 2025 01:13
@Ahmad-S792 Ahmad-S792 added the merge-queue Applied to send a pull request to merge-queue label Jun 26, 2025
https://bugs.webkit.org/show_bug.cgi?id=294837
rdar://154088766

Reviewed by Tim Nguyen.

Upstream commit: web-platform-tests/wpt@a572d07

* LayoutTests/imported/w3c/resources/resource-files.json:
* LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/animation/rotate-transform-equivalent.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/backface-visibility-001.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/backface-visibility-hidden-001.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/group/svg-transform-group-009.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/group/svg-transform-nested-009.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/group/svg-transform-nested-014.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/group/svg-transform-nested-019.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/individual-transform/w3c-import.log:
* LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/parsing/transform-valid-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/parsing/transform-valid.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/perspective-transforms-equivalence.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/preserve3d-and-flattening-001.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/skewX/svg-skewxy-001.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/skewY/svg-skewy-001.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/skewY/svg-skewy-006.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/skewY/svg-skewy-011.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/skewY/svg-skewy-016.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/skewY/svg-skewy-021.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/transform-box/w3c-import.log:
* LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/transform-compound-001-expected.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/transform-compound-001.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/transform-compound-ref.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/transform-input-005.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/transform-percent-008.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/transform3d-sorting-006.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/w3c-import.log:
* LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/3d-point-mapping-2-transforminterop-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/3d-point-mapping-2-transforminterop.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/3d-point-mapping-3-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/3d-point-mapping-3.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/3d-point-mapping-coplanar-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/3d-point-mapping-coplanar.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/3d-point-mapping-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/3d-point-mapping-overlapping-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/3d-point-mapping-overlapping.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/3d-point-mapping.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/css-scale-of-clip-path-expected.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/css-scale-of-clip-path-ref.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/css-scale-of-clip-path.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/individual-transform/individual-transform-3-expected.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/individual-transform/individual-transform-3.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/individual-transform/stacking-context-002-expected.xht
* LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/individual-transform/stacking-context-002.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/individual-transform/stacking-context-003-expected.xht
* LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/individual-transform/stacking-context-003.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/individual-transform/stacking-context-004-expected.xht
* LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/individual-transform/stacking-context-004.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/preserve3d-backface-hit-test-1-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/preserve3d-backface-hit-test-1.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/preserve3d-backface-hit-test-2-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/preserve3d-backface-hit-test-2.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/scale-animation-with-var-001-expected.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/scale-animation-with-var-001.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/scale-transform-filtered-text-expected.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/scale-transform-filtered-text-ref.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/scale-transform-filtered-text.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/transform-box/WEB_FEATURES.yml:
* LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/transform-matrix-009-expected.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/transform-matrix-009.html:

> Platform Specific Expectations:
* LayoutTests/platform/glib/TestExpectations:
* LayoutTests/platform/mac-wk1/TestExpectations:
* LayoutTests/platform/wpe/TestExpectations:

Canonical link: https://commits.webkit.org/296648@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Sync-css-css-transforms-from-WPT-upstream branch from fe5f3e3 to e25d351 Compare June 26, 2025 03:04
@webkit-commit-queue
Copy link
Collaborator

Committed 296648@main (e25d351): https://commits.webkit.org/296648@main

Reviewed commits have been landed. Closing PR #47055 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit e25d351 into WebKit:main Jun 26, 2025
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jun 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CSS Cascading Style Sheets implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants