Skip to content

[WebDriver][BiDi] Fix error forwarding for errors with detail string #47044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lauromoura
Copy link
Contributor

@lauromoura lauromoura commented Jun 23, 2025

f8afe54

[WebDriver][BiDi] Fix error forwarding for errors with detail string
https://bugs.webkit.org/show_bug.cgi?id=294824

Reviewed by NOBODY (OOPS!).

Ensure we check if we're getting an error message with a detail string,
using it for the "message" field in the outgoing BiDi error message.

This avoids getting generic "Unknown Error" with messages
"InvalidParameter;The parameter foo is invalid" if using the
"...AND_DETAILS" macros.

* Source/WebKit/UIProcess/Automation/WebDriverBidiProcessor.cpp:
(WebKit::WebDriverBidiProcessor::sendBidiMessage):

f8afe54

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ⏳ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt loading 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@lauromoura lauromoura requested a review from cdumez as a code owner June 23, 2025 04:21
@lauromoura lauromoura self-assigned this Jun 23, 2025
@lauromoura lauromoura added the WebDriver Bugs in WebDriver label Jun 23, 2025
https://bugs.webkit.org/show_bug.cgi?id=294824

Reviewed by NOBODY (OOPS!).

Ensure we check if we're getting an error message with a detail string,
using it for the "message" field in the outgoing BiDi error message.

This avoids getting generic "Unknown Error" with messages
"InvalidParameter;The parameter foo is invalid" if using the
"...AND_DETAILS" macros.

* Source/WebKit/UIProcess/Automation/WebDriverBidiProcessor.cpp:
(WebKit::WebDriverBidiProcessor::sendBidiMessage):
@lauromoura lauromoura requested a review from burg June 25, 2025 04:17
@lauromoura lauromoura force-pushed the eng/WebDriver-BiDi-Fix-error-forwarding-for-errors-with-detail-string branch from 74630eb to f8afe54 Compare June 25, 2025 04:33
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jun 25, 2025
@lauromoura lauromoura removed the merging-blocked Applied to prevent a change from being merged label Jun 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WebDriver Bugs in WebDriver
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants