Skip to content

New opportunistic CFRunLoop order #47020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 27, 2025
Merged

New opportunistic CFRunLoop order #47020

merged 1 commit into from
Jun 27, 2025

Conversation

Andrew-Fryer
Copy link
Contributor

@Andrew-Fryer Andrew-Fryer commented Jun 21, 2025 •
edited by webkit-early-warning-system
Loading

91bd7b8

New opportunistic CFRunLoop order
https://bugs.webkit.org/show_bug.cgi?id=294792
rdar://153964471

Reviewed by Wenson Hsieh.

Give OpportunisticTaskScheduler a higher CFRunLoop order than
anything else so that it is the last thing to run before sleeping.

* Source/WebCore/page/OpportunisticTaskScheduler.cpp:
(WebCore::OpportunisticTaskScheduler::OpportunisticTaskScheduler):
(WebCore::OpportunisticTaskScheduler::rescheduleIfNeeded):
(WebCore::OpportunisticTaskScheduler::FullGCActivityCallback::FullGCActivityCallback):
* Source/WebCore/platform/RunLoopObserver.h:
* Source/WebCore/platform/cf/RunLoopObserverCF.cpp:
(WebCore::cfRunLoopOrder):

Canonical link: https://commits.webkit.org/296692@main

d54c180

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ⏳ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@Andrew-Fryer Andrew-Fryer requested a review from cdumez as a code owner June 21, 2025 12:20
@Andrew-Fryer Andrew-Fryer self-assigned this Jun 21, 2025
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jun 21, 2025 •
edited
Loading

EWS run on previous version of this PR (hash 373c97c)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2 ⏳ 🧪 win-tests
✅ 🧪 webkitperl   🧪 ios-wk2   🧪 api-mac   🧪 api-wpe
  🧪 ios-wk2-wpt   🧪 mac-wk1 ⏳ 🛠 wpe-cairo
  🧪 api-ios   🧪 mac-wk2   🛠 gtk
✅ 🛠 vision   🧪 mac-AS-debug-wk2   🧪 gtk-wk2
✅ 🛠 vision-sim   🧪 mac-wk2-stress   🧪 api-gtk
  🧪 vision-wk2   🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@Andrew-Fryer Andrew-Fryer added the New Bugs Unclassified bugs are placed in this component until the correct component can be determined. label Jun 21, 2025
@Andrew-Fryer Andrew-Fryer force-pushed the new_opportunistic_CFRunLoop_order branch from 373c97c to d54c180 Compare June 21, 2025 12:22
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jun 21, 2025 •
edited
Loading

EWS run on current version of this PR (hash d54c180)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ⏳ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@Andrew-Fryer Andrew-Fryer requested review from whsieh and mdubet June 24, 2025 16:34
@Andrew-Fryer Andrew-Fryer added the safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks label Jun 26, 2025
@webkit-ews-buildbot webkit-ews-buildbot added merge-queue Applied to send a pull request to merge-queue and removed safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks labels Jun 26, 2025
@webkit-ews-buildbot
Copy link
Collaborator

Safe-Merge-Queue: Build #61511.

@Andrew-Fryer
New opportunistic CFRunLoop order
91bd7b8 
https://bugs.webkit.org/show_bug.cgi?id=294792
rdar://153964471

Reviewed by Wenson Hsieh.

Give OpportunisticTaskScheduler a higher CFRunLoop order than
anything else so that it is the last thing to run before sleeping.

* Source/WebCore/page/OpportunisticTaskScheduler.cpp:
(WebCore::OpportunisticTaskScheduler::OpportunisticTaskScheduler):
(WebCore::OpportunisticTaskScheduler::rescheduleIfNeeded):
(WebCore::OpportunisticTaskScheduler::FullGCActivityCallback::FullGCActivityCallback):
* Source/WebCore/platform/RunLoopObserver.h:
* Source/WebCore/platform/cf/RunLoopObserverCF.cpp:
(WebCore::cfRunLoopOrder):

Canonical link: https://commits.webkit.org/296692@main
@webkit-commit-queue webkit-commit-queue force-pushed the new_opportunistic_CFRunLoop_order branch from d54c180 to 91bd7b8 Compare June 27, 2025 00:06
@webkit-commit-queue
Copy link
Collaborator

Committed 296692@main (91bd7b8): https://commits.webkit.org/296692@main

Reviewed commits have been landed. Closing PR #47020 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 91bd7b8 into WebKit:main Jun 27, 2025
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jun 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whsieh whsieh whsieh approved these changes

@cdumez cdumez Awaiting requested review from cdumez cdumez is a code owner

@mdubet mdubet Awaiting requested review from mdubet

Assignees

@Andrew-Fryer Andrew-Fryer

Labels
New Bugs Unclassified bugs are placed in this component until the correct component can be determined.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Andrew-Fryer @webkit-early-warning-system @webkit-ews-buildbot @webkit-commit-queue @whsieh