Skip to content

Reduce uncounted call arguments in Source/WebKit more #46983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 24, 2025
Merged

Reduce uncounted call arguments in Source/WebKit more #46983

merged 1 commit into from
Jun 24, 2025
+171 −169

Conversation

annevk
Copy link
Contributor

@annevk annevk commented Jun 20, 2025 •
edited by webkit-early-warning-system
Loading

95d0b71

Reduce uncounted call arguments in Source/WebKit more
https://bugs.webkit.org/show_bug.cgi?id=294746

Reviewed by Charlie Wolfe.

Apply https://github.com/WebKit/WebKit/wiki/Safer-CPP-Guidelines

Canonical link: https://commits.webkit.org/296554@main

5a67ee7

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ⏳ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@annevk annevk self-assigned this Jun 20, 2025
@annevk annevk added the WebKit Misc. For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore). label Jun 20, 2025
@webkit-early-warning-system

This comment was marked as outdated.

Sign in to view
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jun 20, 2025
@annevk annevk added skip-ews Applied to prevent a change from being run on EWS and removed merging-blocked Applied to prevent a change from being merged skip-ews Applied to prevent a change from being run on EWS labels Jun 20, 2025
@annevk annevk force-pushed the eng/Reduce-uncounted-call-arguments-in-Source-WebKit-more branch from b32b78d to 7c8527d Compare June 20, 2025 10:41
@webkit-early-warning-system

This comment was marked as outdated.

Sign in to view
@annevk annevk force-pushed the eng/Reduce-uncounted-call-arguments-in-Source-WebKit-more branch from 7c8527d to d5d033b Compare June 20, 2025 10:48
@webkit-early-warning-system

This comment was marked as outdated.

Sign in to view
@webkit-ews-buildbot

This comment was marked as resolved.

Sign in to view
@annevk annevk marked this pull request as ready for review June 20, 2025 12:23
@annevk annevk requested review from aprotyas and cdumez as code owners June 20, 2025 12:23
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jun 20, 2025
@cdumez
Copy link
Contributor

cdumez commented Jun 20, 2025

Looks like there is a new safer cpp failure.

@annevk annevk removed the merging-blocked Applied to prevent a change from being merged label Jun 20, 2025
@annevk annevk force-pushed the eng/Reduce-uncounted-call-arguments-in-Source-WebKit-more branch from d5d033b to 433e036 Compare June 20, 2025 16:15
@webkit-early-warning-system

This comment was marked as outdated.

Sign in to view
@annevk annevk force-pushed the eng/Reduce-uncounted-call-arguments-in-Source-WebKit-more branch from 433e036 to ace0d96 Compare June 20, 2025 18:18
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jun 20, 2025 •
edited
Loading

EWS run on previous version of this PR (hash ace0d96)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ⏳ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@annevk annevk force-pushed the eng/Reduce-uncounted-call-arguments-in-Source-WebKit-more branch from ace0d96 to 5a67ee7 Compare June 21, 2025 07:45
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jun 21, 2025 •
edited
Loading

EWS run on current version of this PR (hash 5a67ee7)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ⏳ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jun 21, 2025
@annevk annevk removed the merging-blocked Applied to prevent a change from being merged label Jun 23, 2025
@annevk annevk added the merge-queue Applied to send a pull request to merge-queue label Jun 24, 2025
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Reduce-uncounted-call-arguments-in-Source-WebKit-more branch from 5a67ee7 to 95d0b71 Compare June 24, 2025 06:20
@webkit-commit-queue webkit-commit-queue merged commit 95d0b71 into WebKit:main Jun 24, 2025
@webkit-commit-queue
Copy link
Collaborator

Committed 296554@main (95d0b71): https://commits.webkit.org/296554@main

Reviewed commits have been landed. Closing PR #46983 and removing active labels.

@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jun 24, 2025
@annevk annevk deleted the eng/Reduce-uncounted-call-arguments-in-Source-WebKit-more branch June 24, 2025 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charliewolfe charliewolfe charliewolfe approved these changes

@aprotyas aprotyas Awaiting requested review from aprotyas aprotyas is a code owner

@cdumez cdumez Awaiting requested review from cdumez cdumez is a code owner

Assignees

@annevk annevk

Labels
WebKit Misc. For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@annevk @webkit-early-warning-system @webkit-ews-buildbot @cdumez @webkit-commit-queue @charliewolfe