Skip to content

[WPE] On wayland fallback to libdrm for device detection if other methods are unsupported #46972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 24, 2025
Merged

[WPE] On wayland fallback to libdrm for device detection if other methods are unsupported #46972

merged 1 commit into from
Jun 24, 2025
+118 −26

Conversation

TingPing
Copy link
Contributor

@TingPing TingPing commented Jun 19, 2025 •
edited by webkit-early-warning-system
Loading

ee58a81

[WPE] On wayland fallback to libdrm for device detection if other methods are unsupported
https://bugs.webkit.org/show_bug.cgi?id=294737

Reviewed by Carlos Garcia Campos.

Older compositors will not support zwp_linux_dmabuf_v1_get_default_feedback.

Some drivers, specifically libmali, do not support EGL_EXT_device_query.

In such a case we can at least try the first device from libdrm.

Canonical link: https://commits.webkit.org/296563@main

a356d3e

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ⏳ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ❌ 🧪 api-gtk
✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 🧪 unsafe-merge ✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@TingPing TingPing requested a review from a team as a code owner June 19, 2025 18:29
@TingPing TingPing self-assigned this Jun 19, 2025
@webkit-early-warning-system

This comment was marked as outdated.

Sign in to view
@TingPing TingPing added the WPE WebKit WebKit WPE component label Jun 19, 2025
@TingPing TingPing force-pushed the pgriffis/wpe-egl-device-query branch from a90cc5a to 1e21b99 Compare June 19, 2025 18:34
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jun 19, 2025 •
edited
Loading

EWS run on previous version of this PR (hash 1e21b99)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ⏳ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ⏳ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
❌ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ❌ 🧪 api-gtk
⏳ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

carlosgcampos
carlosgcampos approved these changes Jun 20, 2025
View reviewed changes
spenap
spenap reviewed Jun 20, 2025
View reviewed changes
@TingPing TingPing force-pushed the pgriffis/wpe-egl-device-query branch from 1e21b99 to fd5b2b0 Compare June 22, 2025 21:47
@webkit-early-warning-system

This comment was marked as outdated.

Sign in to view
@TingPing TingPing added the safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks label Jun 22, 2025
@TingPing TingPing force-pushed the pgriffis/wpe-egl-device-query branch from fd5b2b0 to a356d3e Compare June 22, 2025 21:55
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jun 22, 2025 •
edited
Loading

EWS run on current version of this PR (hash a356d3e)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ⏳ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ❌ 🧪 api-gtk
✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 🧪 unsafe-merge ✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@webkit-ews-buildbot
Copy link
Collaborator

Failed api-gtk checks. Please resolve failures and re-apply safe-merge-queue label.

Rejecting #46972 from merge queue.

@webkit-ews-buildbot webkit-ews-buildbot removed the safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks label Jun 22, 2025
@webkit-ews-buildbot
Copy link
Collaborator

Safe-Merge-Queue: Build #61126.

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jun 22, 2025
@TingPing TingPing added unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing GLib Suggested Backport - 2.48 Suggest this merge request be backported to webkitglib/2.48 branch and removed merging-blocked Applied to prevent a change from being merged labels Jun 24, 2025
@TingPing
[WPE] On wayland fallback to libdrm for device detection if other met…
ee58a81 
…hods are unsupported

https://bugs.webkit.org/show_bug.cgi?id=294737

Reviewed by Carlos Garcia Campos.

Older compositors will not support zwp_linux_dmabuf_v1_get_default_feedback.

Some drivers, specifically libmali, do not support EGL_EXT_device_query.

In such a case we can at least try the first device from libdrm.

Canonical link: https://commits.webkit.org/296563@main
@webkit-commit-queue webkit-commit-queue force-pushed the pgriffis/wpe-egl-device-query branch from a356d3e to ee58a81 Compare June 24, 2025 15:02
@webkit-commit-queue
Copy link
Collaborator

Committed 296563@main (ee58a81): https://commits.webkit.org/296563@main

Reviewed commits have been landed. Closing PR #46972 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit ee58a81 into WebKit:main Jun 24, 2025
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jun 24, 2025
@aperezdc
Copy link
Contributor

Backported into webkitglib/2.48 as commit 765da23

@aperezdc aperezdc removed the GLib Suggested Backport - 2.48 Suggest this merge request be backported to webkitglib/2.48 branch label Jun 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spenap spenap spenap left review comments

@carlosgcampos carlosgcampos carlosgcampos approved these changes

Assignees

@TingPing TingPing

Labels
WPE WebKit WebKit WPE component
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@TingPing @webkit-early-warning-system @webkit-ews-buildbot @webkit-commit-queue @aperezdc @spenap @carlosgcampos