-
Notifications
You must be signed in to change notification settings - Fork 1.6k
WebKit: convert UChar to char16_t #46967
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
adetaylor
wants to merge
1
commit into
WebKit:main
Choose a base branch
from
adetaylor:eng/WebKit-convert-UChar-to-char16_t
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
WebKit: convert UChar to char16_t #46967
adetaylor
wants to merge
1
commit into
WebKit:main
from
adetaylor:eng/WebKit-convert-UChar-to-char16_t
+35
−35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
EWS run on previous version of this PR (hash 0bf67ce) |
achristensen07
approved these changes
Jun 19, 2025
e5e1809
to
194772a
Compare
merge-queue failed to commit PR to repository. To retry, remove any blocking labels and re-apply merge-queue label |
https://bugs.webkit.org/show_bug.cgi?id=294733 rdar://153823213 Reviewed by NOBODY (OOPS!). WebKit would like to switch from UChar to the C++ standard char16_t. This PR makes the change for the Source/WebKit and Source/WebKitLegacy directories. This is a simple textual substitution of \bUChar\b to char16_t. As these types are currently typedefed to be identical, no functional changes are expected. One file was excluded from this: Source/WebKitLegacy/ios/Misc/WebUIKitSupport.h because this file is included in plain [objective-C] code as well as C++ code, where char16_t does not exist (it's a C++ type). * Source/WebKit/NetworkProcess/NetworkLoadChecker.cpp: (WebKit::NetworkLoadChecker::checkTAO): * Source/WebKit/NetworkProcess/soup/WebSocketTaskSoup.cpp: (WebKit::WebSocketTask::WebSocketTask): * Source/WebKit/NetworkProcess/storage/CacheStorageRecord.cpp: (WebKit::CacheStorageRecordInformation::updateVaryHeaders): * Source/WebKit/Platform/IPC/ArgumentCoders.cpp: (IPC::ArgumentCoder<String>::decode): * Source/WebKit/Platform/IPC/DaemonCoders.h: (WebKit::Daemon::Coder<WTF::String>::decode): * Source/WebKit/Shared/API/c/WKString.cpp: (WKStringGetCharacters): * Source/WebKit/Shared/Extensions/WebExtensionLocalization.cpp: (WebKit::WebExtensionLocalization::stringByReplacingPositionalPlaceholdersInString): * Source/WebKit/Shared/Extensions/WebExtensionUtilities.cpp: (WebKit::toErrorString): * Source/WebKit/Shared/win/WebEventFactory.cpp: (WebKit::textFromEvent): (WebKit::unmodifiedTextFromEvent): * Source/WebKit/UIProcess/API/APIContentRuleListStore.cpp: (API::compiledToFile): (API::getContentRuleListSourceFromMappedFile): * Source/WebKit/UIProcess/API/gtk/DropTargetGtk3.cpp: (WebKit::DropTarget::dataReceived): * Source/WebKit/UIProcess/API/gtk/DropTargetGtk4.cpp: (WebKit::DropTarget::accept): * Source/WebKit/UIProcess/mac/LegacySessionStateCoding.cpp: (WebKit::HistoryEntryDataEncoder::operator<<): (WebKit::HistoryEntryDataDecoder::operator>>): * Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm: (WebKit::UnifiedPDFPlugin::revealFragmentIfNeeded): * Source/WebKit/WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::shouldSkipDecidePolicyForResponse const): * Source/WebKit/webpushd/PushClientConnection.mm: (WebPushD::isValidPushPartition): * Source/WebKitLegacy/ios/Misc/WebUIKitSupport.mm: (WebKitGetLastLineBreakInBuffer): * Source/WebKitLegacy/mac/Misc/WebKitNSStringExtras.mm: (-[NSString _web_drawAtPoint:font:textColor:]): (-[NSString _web_widthWithFont:]): * Source/WebKitLegacy/mac/WebCoreSupport/WebVisitedLinkStore.mm: (WebVisitedLinkStore::addVisitedLink): * Source/WebKitLegacy/mac/WebView/WebFrame.mm: (-[WebFrame _smartInsertForString:replacingRange:beforeString:afterString:]):
194772a
to
b01ddaa
Compare
EWS run on current version of this PR (hash b01ddaa) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
unsafe-merge-queue
Applied to send a pull request to merge-queue, but skip building and testing
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
194772a
b01ddaa
🛠 playstation