Skip to content

WebGPU: Replace UChar with char16_t #46965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 30, 2025
Merged

WebGPU: Replace UChar with char16_t #46965

merged 1 commit into from
Jun 30, 2025
+5 −5

Conversation

adetaylor
Copy link
Contributor

@adetaylor adetaylor commented Jun 19, 2025 •
edited by webkit-early-warning-system
Loading

f3097d8

WebGPU: Replace UChar with char16_t
https://bugs.webkit.org/show_bug.cgi?id=294730
rdar://153822449

Reviewed by Alex Christensen.

WebKit wishes to move from UChar to the standard C++ chat16_t. This PR makes
the change in Source/WebGPU; it's a simple textual replacement of \bUChar\b
with char16_t. These are typedef'd to be the same so no functional differences
are expected.

* Source/WebGPU/WGSL/Lexer.cpp:
(WGSL::isIdentifierStart):
(WGSL::isIdentifierContinue):
* Source/WebGPU/WGSL/Lexer.h:
(WGSL::Lexer::Lexer):
* Source/WebGPU/WGSL/Parser.cpp:
(WGSL::parse):

Canonical link: https://commits.webkit.org/296800@main

7f8fedb

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ⏳ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2   🛠 playstation
✅ 🛠 🧪 unsafe-merge ✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jun 19, 2025 •
edited
Loading

EWS run on current version of this PR (hash 7f8fedb)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ⏳ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2   🛠 playstation
✅ 🛠 🧪 unsafe-merge ✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@adetaylor adetaylor mentioned this pull request Jun 19, 2025
Closed
@achristensen07 achristensen07 added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jun 30, 2025
@adetaylor @achristensen07
WebGPU: Replace UChar with char16_t
f3097d8 
https://bugs.webkit.org/show_bug.cgi?id=294730
rdar://153822449

Reviewed by Alex Christensen.

WebKit wishes to move from UChar to the standard C++ chat16_t. This PR makes
the change in Source/WebGPU; it's a simple textual replacement of \bUChar\b
with char16_t. These are typedef'd to be the same so no functional differences
are expected.

* Source/WebGPU/WGSL/Lexer.cpp:
(WGSL::isIdentifierStart):
(WGSL::isIdentifierContinue):
* Source/WebGPU/WGSL/Lexer.h:
(WGSL::Lexer::Lexer):
* Source/WebGPU/WGSL/Parser.cpp:
(WGSL::parse):

Canonical link: https://commits.webkit.org/296800@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/WebGPU-Replace-UChar-with-char16_t branch from 7f8fedb to f3097d8 Compare June 30, 2025 16:14
@webkit-commit-queue
Copy link
Collaborator

Committed 296800@main (f3097d8): https://commits.webkit.org/296800@main

Reviewed commits have been landed. Closing PR #46965 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit f3097d8 into WebKit:main Jun 30, 2025
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jun 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@achristensen07 achristensen07 achristensen07 approved these changes

@mwyrzykowski mwyrzykowski Awaiting requested review from mwyrzykowski mwyrzykowski is a code owner

@djg djg Awaiting requested review from djg djg is a code owner

@tadeuzagallo tadeuzagallo Awaiting requested review from tadeuzagallo tadeuzagallo is a code owner

Assignees

@adetaylor adetaylor

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@adetaylor @webkit-early-warning-system @webkit-commit-queue @achristensen07