Skip to content

WebDriver: convert UChar to char16_t #46964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 30, 2025
Merged

WebDriver: convert UChar to char16_t #46964

merged 1 commit into from
Jun 30, 2025
+2 −2

Conversation

adetaylor
Copy link
Contributor

@adetaylor adetaylor commented Jun 19, 2025 •
edited by webkit-early-warning-system
Loading

915ed3d

WebDriver: convert UChar to char16_t
https://bugs.webkit.org/show_bug.cgi?id=294729
rdar://153822236

Reviewed by Alex Christensen.

WebKit wishes to move from UChar to the C++ standard char16_t, now this is
universally supported. This makes the change in WebDriver. This is a simple
textual substitution of \bUChar\b with char16_t. These types are currently
typedef'ed to be the same so no functional changes are expected.

* Source/WebDriver/Session.cpp:
(WebDriver::Session::virtualKeyForKey):
* Source/WebDriver/Session.h:

Canonical link: https://commits.webkit.org/296801@main

a172735

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ⏳ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2   🛠 playstation
✅ 🛠 🧪 unsafe-merge ✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@adetaylor adetaylor requested a review from carlosgcampos as a code owner June 19, 2025 13:39
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jun 19, 2025 •
edited
Loading

EWS run on current version of this PR (hash a172735)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ⏳ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2   🛠 playstation
✅ 🛠 🧪 unsafe-merge ✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@adetaylor adetaylor mentioned this pull request Jun 19, 2025
Closed
@achristensen07 achristensen07 added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jun 30, 2025
@webkit-commit-queue webkit-commit-queue force-pushed the eng/WebDriver-convert-UChar-to-char16_t branch from a172735 to dfb3446 Compare June 30, 2025 16:14
@adetaylor @achristensen07
WebDriver: convert UChar to char16_t
915ed3d 
https://bugs.webkit.org/show_bug.cgi?id=294729
rdar://153822236

Reviewed by Alex Christensen.

WebKit wishes to move from UChar to the C++ standard char16_t, now this is
universally supported. This makes the change in WebDriver. This is a simple
textual substitution of \bUChar\b with char16_t. These types are currently
typedef'ed to be the same so no functional changes are expected.

* Source/WebDriver/Session.cpp:
(WebDriver::Session::virtualKeyForKey):
* Source/WebDriver/Session.h:

Canonical link: https://commits.webkit.org/296801@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/WebDriver-convert-UChar-to-char16_t branch from dfb3446 to 915ed3d Compare June 30, 2025 16:16
@webkit-commit-queue
Copy link
Collaborator

Committed 296801@main (915ed3d): https://commits.webkit.org/296801@main

Reviewed commits have been landed. Closing PR #46964 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 915ed3d into WebKit:main Jun 30, 2025
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jun 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@achristensen07 achristensen07 achristensen07 approved these changes

@carlosgcampos carlosgcampos Awaiting requested review from carlosgcampos carlosgcampos is a code owner

Assignees

@adetaylor adetaylor

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@adetaylor @webkit-early-warning-system @webkit-commit-queue @achristensen07