Skip to content

[GTK][WPE][Skia] Fix LoongArch build failure #46949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 25, 2025
Merged

[GTK][WPE][Skia] Fix LoongArch build failure #46949

merged 1 commit into from
Jun 25, 2025

Conversation

xry111
Copy link
Contributor

@xry111 xry111 commented Jun 19, 2025 •
edited by webkit-early-warning-system
Loading

7565d2c

[GTK][WPE][Skia] Fix LoongArch build failure
https://bugs.webkit.org/show_bug.cgi?id=280505

Reviewed by Adrian Perez de Castro.

The shipped skia code fails to build as at now because some files are
missing from the cmake building system.  Add those files and work around
some issues building them with GCC.

* Source/ThirdParty/skia/CMakeLists.txt:

Canonical link: https://commits.webkit.org/296614@main

183c315

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ⏳ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2   🛠 playstation
✅ 🛠 🧪 unsafe-merge ✅ 🛠 tv
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jun 19, 2025 •
edited
Loading

EWS run on previous version of this PR (hash 20b5020)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ⏳ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2   🛠 playstation
✅ 🛠 tv
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@xry111 xry111 mentioned this pull request Jun 19, 2025
Open
@carlosgcampos carlosgcampos requested a review from aperezdc June 19, 2025 08:16
@xry111 xry111 marked this pull request as draft June 19, 2025 09:12
@xry111
Copy link
Contributor Author

xry111 commented Jun 19, 2025

There seem some other file(s) requiring -flax-vector-conversion on LoongArch. I'll investigate more.

@xry111 xry111 force-pushed the xry111/skia-loong branch from 20b5020 to 183c315 Compare June 19, 2025 12:37
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jun 19, 2025 •
edited
Loading

EWS run on current version of this PR (hash 183c315)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ⏳ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2   🛠 playstation
✅ 🛠 🧪 unsafe-merge ✅ 🛠 tv
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

xry111 added a commit to AOSC-Tracking/WebKit that referenced this pull request Jun 19, 2025
@xry111
[GTK][WPE][Skia] Fix LoongArch build failure
863db94 
https://bugs.webkit.org/show_bug.cgi?id=280505

Reviewed by NOBODY (OOPS!).

The shipped skia code fails to build as at now because some files are
missing from the cmake building system.  Add those files and work around
some issues building them with GCC.

* Source/ThirdParty/skia/CMakeLists.txt:

Link: WebKit/WebKit#46949
Signed-off-by: Xi Ruoyao <[email protected]>
xry111 added a commit to AOSC-Tracking/WebKit that referenced this pull request Jun 19, 2025
@xry111
[GTK][WPE][Skia] Fix LoongArch build failure
4fb38da 
https://bugs.webkit.org/show_bug.cgi?id=280505

Reviewed by NOBODY (OOPS!).

The shipped skia code fails to build as at now because some files are
missing from the cmake building system.  Add those files and work around
some issues building them with GCC.

* Source/ThirdParty/skia/CMakeLists.txt:

Link: WebKit/WebKit#46949
Signed-off-by: Xi Ruoyao <[email protected]>
@xry111 xry111 marked this pull request as ready for review June 19, 2025 16:31
@xry111
Copy link
Contributor Author

xry111 commented Jun 19, 2025

The patch allows to build the latest webkitgtk stable for our distro: https://buildit.aosc.io/jobs/91173

@aperezdc aperezdc added GLib Suggested Backport - 2.48 Suggest this merge request be backported to webkitglib/2.48 branch unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing labels Jun 25, 2025
@xry111 @aperezdc
[GTK][WPE][Skia] Fix LoongArch build failure
7565d2c 
https://bugs.webkit.org/show_bug.cgi?id=280505

Reviewed by Adrian Perez de Castro.

The shipped skia code fails to build as at now because some files are
missing from the cmake building system.  Add those files and work around
some issues building them with GCC.

* Source/ThirdParty/skia/CMakeLists.txt:

Canonical link: https://commits.webkit.org/296614@main
@webkit-commit-queue
Copy link
Collaborator

Committed 296614@main (7565d2c): https://commits.webkit.org/296614@main

Reviewed commits have been landed. Closing PR #46949 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 7565d2c into WebKit:main Jun 25, 2025
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jun 25, 2025
@aperezdc
Copy link
Contributor

Backported into webkitglib/2.48 as commit 0f524e0

@aperezdc aperezdc removed the GLib Suggested Backport - 2.48 Suggest this merge request be backported to webkitglib/2.48 branch label Jun 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aperezdc aperezdc aperezdc approved these changes

@alexgcastro alexgcastro Awaiting requested review from alexgcastro alexgcastro is a code owner

@carlosgcampos carlosgcampos Awaiting requested review from carlosgcampos carlosgcampos is a code owner

@nikolaszimmermann nikolaszimmermann Awaiting requested review from nikolaszimmermann nikolaszimmermann is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xry111 @webkit-early-warning-system @webkit-commit-queue @aperezdc