-
Notifications
You must be signed in to change notification settings - Fork 1.6k
[WTF] Refactor normalizedFloat
and Add Test Cases
#46942
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[WTF] Refactor normalizedFloat
and Add Test Cases
#46942
Conversation
EWS run on previous version of this PR (hash aac1517) |
aac1517
to
4c612e8
Compare
EWS run on previous version of this PR (hash 4c612e8) |
4c612e8
to
b58881d
Compare
EWS run on previous version of this PR (hash b58881d) |
https://bugs.webkit.org/show_bug.cgi?id=294707 Reviewed by NOBODY (OOPS!). This patch refactors `normalizedFloat` and added test cases. * Source/WTF/wtf/MathExtras.h: (normalizedFloat): * Tools/TestWebKitAPI/Tests/WTF/MathExtras.cpp: (TestWebKitAPI::TEST(WTF, normalizedFloat)):
b58881d
to
e888ea4
Compare
EWS run on current version of this PR (hash e888ea4) |
Why refactor? Is this smaller or faster than the old code? |
I think it's slightly faster because of less branches and less comparison. |
An interesting guess. Or maybe it’s slightly slower because of library function call overhead that might not be optimized away. I wonder which guess is correct. |
Hmm interesting. |
e888ea4
e888ea4
🛠 playstation