Simplify SVGPathBlender::blendArcToSegment #46896
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://bugs.webkit.org/show_bug.cgi?id=265914 Reviewed by NOBODY (OOPS!). Merge: https://chromium.googlesource.com/chromium/blink/+/d5b67fa7c1c3767bd4f384adb8c43875e632bef5 By factoring the "simple" (same coordinate type) case out of SVGPathBlender::blendAnimatedFloatPoint, we can simplify the blending of rx/ry/angle of two arc segments. Additionally, since the m_fromMode == m_toMode if m_addTypesCount != 0, the same expression can be used to determine the mode of the blended segment. * Source/WebCore/svg/SVGPathBlender.cpp: (WebCore::SVGPathBlender::blendAnimatedFloatPointSameCoordinates): (WebCore::SVGPathBlender::blendAnimatedFloatPoint): (WebCore::SVGPathBlender::blendArcToSegment): * Source/WebCore/svg/SVGPathBlender.h:
|
EWS run on current version of this PR (hash 61f5d56) |
| if (m_fromMode == m_toMode) | ||
| return blendFloatPoint(fromPoint, toPoint, progress); | ||
| return blendAnimatedFloatPointSameCoordinates(fromPoint, toPoint, progress); |
There was a problem hiding this comment.
This now handles the case of m_addTypeCount is > 0. This was not the case before, just wanted to point it out, did not check the implications.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
61f5d56
61f5d56