Skip to content

Re-import WPT css/css-fonts (and fixing css-fonts/font-variant-caps-invalidation-container-sizing.html) #46829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 27, 2025
Merged

Re-import WPT css/css-fonts (and fixing css-fonts/font-variant-caps-invalidation-container-sizing.html) #46829

merged 1 commit into from
Jun 27, 2025
+140 −29

Conversation

vitorroriz
Copy link
Contributor

@vitorroriz vitorroriz commented Jun 17, 2025 •
edited by webkit-early-warning-system
Loading

f8215a3

Re-import WPT css/css-fonts (and fixing css-fonts/font-variant-caps-invalidation-container-sizing.html)
rdar://153586209
https://bugs.webkit.org/show_bug.cgi?id=294588

Reviewed by Tim Nguyen.

Besides re-importing css/css-fonts we are also fixing css-fonts/font-variant-caps-invalidation-container-sizing.html.
The test is missing an id attribute for style to be applied.

* LayoutTests/imported/w3c/resources/resource-files.json:
* LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/animations/w3c-import.log:
* LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/calc-in-font-variation-settings-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/calc-in-font-variation-settings.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/font-display/w3c-import.log:
* LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/font-variant-caps-invalidation-container-sizing-expected.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/font-variant-caps-invalidation-container-sizing-ref.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/font-variant-caps-invalidation-container-sizing.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/matching/font-unicode-presented-as-emoji-outline-expected.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/matching/font-unicode-presented-as-emoji-outline-ref.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/matching/font-unicode-presented-as-emoji-outline.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/matching/resources/AhemCrossmarkSupport.otf: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/matching/resources/w3c-import.log:
* LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/matching/w3c-import.log:
* LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/math-script-level-and-math-style/w3c-import.log:
* LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/w3c-import.log:
* LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/resources/vs/w3c-import.log:
* LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/resources/w3c-import.log:
* LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/support/css/w3c-import.log:
* LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/support/fonts/gsubtest-lookup3.ufo/glyphs/w3c-import.log:
* LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/support/fonts/gsubtest-lookup3.ufo/w3c-import.log:
* LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/support/fonts/w3c-import.log:
* LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/support/js/w3c-import.log:
* LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/support/w3c-import.log:
* LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/variations/at-font-face-descriptors-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/variations/at-font-face-descriptors.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/variations/resources/w3c-import.log:
* LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/variations/w3c-import.log:
* LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/w3c-import.log:

Canonical link: https://commits.webkit.org/296696@main

910776c

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ⏳ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 tv
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@vitorroriz vitorroriz self-assigned this Jun 17, 2025
@vitorroriz vitorroriz added the Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases label Jun 17, 2025
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jun 17, 2025 •
edited
Loading

EWS run on previous version of this PR (hash caa8f84)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ❌ 🧪 wpe-wk2 ⏳ 🧪 win-tests
✅ 🧪 webkitperl ❌ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
❌ 🧪 ios-wk2-wpt ❌ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ❌ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ❌ 🧪 mac-AS-debug-wk2 ❌ 🧪 gtk-wk2
✅ 🛠 vision-sim ❌ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🧪 vision-wk2 ❌ 🧪 mac-intel-wk2   🛠 playstation
✅ 🛠 tv
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@vitorroriz vitorroriz requested review from nt1m and gsnedders June 17, 2025 00:25
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jun 17, 2025
@vitorroriz vitorroriz removed the merging-blocked Applied to prevent a change from being merged label Jun 24, 2025
@vitorroriz vitorroriz force-pushed the eng/Re-import-WPT-css-css-fonts branch from caa8f84 to e9896ec Compare June 24, 2025 23:14
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jun 24, 2025 •
edited
Loading

EWS run on previous version of this PR (hash e9896ec)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ⏳ 🛠 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2 ⏳ 🧪 win-tests
✅ 🧪 webkitperl   🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
⏳ 🧪 ios-wk2-wpt   🧪 mac-wk1 ✅ 🛠 wpe-cairo
⏳ 🛠 🧪 jsc ✅ 🧪 api-ios   🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ⏳ 🧪 mac-AS-debug-wk2 ⏳ 🧪 gtk-wk2
✅ 🛠 vision-sim ❌ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🧪 vision-wk2   🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 tv
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@vitorroriz vitorroriz force-pushed the eng/Re-import-WPT-css-css-fonts branch from e9896ec to 8d6f5da Compare June 24, 2025 23:55
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jun 24, 2025 •
edited
Loading

EWS run on previous version of this PR (hash 8d6f5da)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ⏳ 🛠 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2 ⏳ 🧪 win-tests
✅ 🧪 webkitperl ❌ 🧪 ios-wk2   🧪 api-mac ✅ 🧪 api-wpe
⏳ 🧪 ios-wk2-wpt   🧪 mac-wk1 ✅ 🛠 wpe-cairo
⏳ 🛠 🧪 jsc ✅ 🧪 api-ios   🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ⏳ 🧪 mac-AS-debug-wk2   🧪 gtk-wk2
✅ 🛠 vision-sim   🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🧪 vision-wk2   🧪 mac-intel-wk2 ⏳ 🛠 playstation
✅ 🛠 tv ⏳ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@vitorroriz vitorroriz requested a review from sammygill June 25, 2025 00:02
@vitorroriz vitorroriz changed the title Re-import WPT css/css-fonts Re-import WPT css/css-fonts (and fixing css-fonts/font-variant-caps-invalidation-container-sizing.html) Jun 25, 2025
@vitorroriz vitorroriz force-pushed the eng/Re-import-WPT-css-css-fonts branch from 8d6f5da to c361f13 Compare June 25, 2025 00:03
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jun 25, 2025 •
edited
Loading

EWS run on previous version of this PR (hash c361f13)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
loading 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ❌ 🧪 wpe-wk2 ⏳ 🧪 win-tests
✅ 🧪 webkitperl ❌ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
❌ 🧪 ios-wk2-wpt ❌ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ❌ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ❌ 🧪 mac-AS-debug-wk2 ❌ 🧪 gtk-wk2
✅ 🛠 vision-sim ❌ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🧪 vision-wk2 ❌ 🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 tv
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@vitorroriz vitorroriz added the safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks label Jun 25, 2025
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jun 25, 2025
@webkit-ews-buildbot
Copy link
Collaborator

Failed ios-wk2, ios-wk2-wpt, mac-wk1, mac-wk2, mac-AS-debug-wk2, mac-wk2-stress, gtk-wk2, wpe-wk2 checks. Please resolve failures and re-apply safe-merge-queue label.

Rejecting #46829 from merge queue.

@webkit-ews-buildbot webkit-ews-buildbot removed the safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks label Jun 25, 2025
@webkit-ews-buildbot
Copy link
Collaborator

Safe-Merge-Queue: Build #61353.

@vitorroriz vitorroriz removed the merging-blocked Applied to prevent a change from being merged label Jun 26, 2025
@vitorroriz vitorroriz force-pushed the eng/Re-import-WPT-css-css-fonts branch from c361f13 to 910776c Compare June 26, 2025 22:06
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jun 26, 2025 •
edited
Loading

EWS run on current version of this PR (hash 910776c)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ⏳ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 tv
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@vitorroriz vitorroriz added safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks merge-queue Applied to send a pull request to merge-queue labels Jun 26, 2025
@webkit-ews-buildbot webkit-ews-buildbot removed the safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks label Jun 27, 2025
@webkit-ews-buildbot
Copy link
Collaborator

Safe-Merge-Queue: Build #61514.

@vitorroriz
Re-import WPT css/css-fonts (and fixing css-fonts/font-variant-caps-i…
f8215a3 
…nvalidation-container-sizing.html)

rdar://153586209
https://bugs.webkit.org/show_bug.cgi?id=294588

Reviewed by Tim Nguyen.

Besides re-importing css/css-fonts we are also fixing css-fonts/font-variant-caps-invalidation-container-sizing.html.
The test is missing an id attribute for style to be applied.

* LayoutTests/imported/w3c/resources/resource-files.json:
* LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/animations/w3c-import.log:
* LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/calc-in-font-variation-settings-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/calc-in-font-variation-settings.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/font-display/w3c-import.log:
* LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/font-variant-caps-invalidation-container-sizing-expected.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/font-variant-caps-invalidation-container-sizing-ref.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/font-variant-caps-invalidation-container-sizing.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/matching/font-unicode-presented-as-emoji-outline-expected.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/matching/font-unicode-presented-as-emoji-outline-ref.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/matching/font-unicode-presented-as-emoji-outline.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/matching/resources/AhemCrossmarkSupport.otf: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/matching/resources/w3c-import.log:
* LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/matching/w3c-import.log:
* LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/math-script-level-and-math-style/w3c-import.log:
* LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/w3c-import.log:
* LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/resources/vs/w3c-import.log:
* LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/resources/w3c-import.log:
* LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/support/css/w3c-import.log:
* LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/support/fonts/gsubtest-lookup3.ufo/glyphs/w3c-import.log:
* LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/support/fonts/gsubtest-lookup3.ufo/w3c-import.log:
* LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/support/fonts/w3c-import.log:
* LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/support/js/w3c-import.log:
* LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/support/w3c-import.log:
* LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/variations/at-font-face-descriptors-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/variations/at-font-face-descriptors.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/variations/resources/w3c-import.log:
* LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/variations/w3c-import.log:
* LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/w3c-import.log:

Canonical link: https://commits.webkit.org/296696@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Re-import-WPT-css-css-fonts branch from 910776c to f8215a3 Compare June 27, 2025 00:52
@webkit-commit-queue
Copy link
Collaborator

Committed 296696@main (f8215a3): https://commits.webkit.org/296696@main

Reviewed commits have been landed. Closing PR #46829 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit f8215a3 into WebKit:main Jun 27, 2025
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jun 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nt1m nt1m nt1m approved these changes

@gsnedders gsnedders Awaiting requested review from gsnedders

@sammygill sammygill Awaiting requested review from sammygill

Assignees

@vitorroriz vitorroriz

Labels
Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vitorroriz @webkit-early-warning-system @webkit-ews-buildbot @webkit-commit-queue @nt1m