Move hostnames and URL for Steps into Password util #46721
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdar://153325092 https://bugs.webkit.org/show_bug.cgi?id=294461 Reviewed by NOBODY (OOPS!). Move hostnames and URL for Steps into Password util * Tools/CISupport/ews-build/steps.py:
d8e87c2 to
560daaf
Compare
JonWBedard
approved these changes
Jun 17, 2025
aj062
requested changes
Jun 17, 2025
| TESTING_ENVIRONMENT_HOSTNAMES = ['ews-build.webkit-uat.org', 'ews-build-uat', 'ews-build.webkit-dev.org', 'ews-build-dev'] | ||
| EWS_URL = 'https://ews.webkit.org/' | ||
| EWS_URL = load_password('EWS_BUILD_HOSTNAMES', default='https://ews.webkit.org/') |
There was a problem hiding this comment.
EWS_BUILD_HOSTNAMES doesn't seem accurate, it's not the hostname for buildbot (e.g: ews-build.webkit.org), it's the hostname for the django app (e.g.: ews.webkit.org). Plus you are already using this name above in line 62 for different purpose.
Can name it EWS_APP_HOSTNAME.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
560daaf