Move Loading URLs in master.cfg into Password util #46717
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdar://153315442 https://bugs.webkit.org/show_bug.cgi?id=294447 Reviewed by NOBODY (OOPS!). Move Loading URLs in master.cfg into Password util * Tools/CISupport/ews-build/master.cfg:
3f8d839 to
f1ff3d0
Compare
JonWBedard
approved these changes
Jun 17, 2025
aj062
approved these changes
Jun 17, 2025
| @@ -59,7 +59,7 @@ if is_test_mode_enabled: | |||
| c['buildbotURL'] = 'http://localhost:8010/' | |||
| c['db_url'] = 'sqlite:///state.sqlite?serialize_access=1' | |||
| else: | |||
| c['buildbotURL'] = 'https://ews-build.webkit{}.org/'.format(custom_suffix) | |||
| c['buildbotURL'] = utils.load_password('MASTERCFG_BUILDBOT_URL', default='https://ews-build.webkit{}.org/'.format(custom_suffix)) | |||
There was a problem hiding this comment.
Let's use f-string while we are at it. In general we want to convert all the .format to f-string.
Nit: MASTERCFG_BUILDBOT_URL can simply be BUILDBOT_URL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
f1ff3d0