Skip to content

Move Loading of EVENT_SERVER_ENDPOINT into Password util #46715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Move Loading of EVENT_SERVER_ENDPOINT into Password util #46715

wants to merge 1 commit into from

Conversation

chgibb-apple
Copy link
Contributor

@chgibb-apple chgibb-apple commented Jun 13, 2025 •
edited
Loading

ccd469f

Move Loading of EVENT_SERVER_ENDPOINT into Password util
rdar://153314993
https://bugs.webkit.org/show_bug.cgi?id=294446

Reviewed by NOBODY (OOPS!).

Move Loading of EVENT_SERVER_ENDPOINT into Password util

* Tools/CISupport/ews-build/events.py:
(Events):

@chgibb-apple chgibb-apple self-assigned this Jun 13, 2025
@chgibb-apple chgibb-apple added the Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases label Jun 13, 2025
bls1999
bls1999 approved these changes Jun 13, 2025
View reviewed changes
Copy link
Contributor

@bls1999 bls1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unofficial r+

@chgibb-apple
Move Loading of EVENT_SERVER_ENDPOINT into Password util
ccd469f 
rdar://153314993
https://bugs.webkit.org/show_bug.cgi?id=294446

Reviewed by NOBODY (OOPS!).

Move Loading of EVENT_SERVER_ENDPOINT into Password util

* Tools/CISupport/ews-build/events.py:
(Events):
@chgibb-apple chgibb-apple force-pushed the eng/Move-Loading-of-EVENT_SERVER_ENDPOINT-into-Password-util branch from 554df28 to ccd469f Compare June 13, 2025 23:40
@chgibb-apple chgibb-apple added safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks and removed safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks labels Jun 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bls1999 bls1999 bls1999 approved these changes

@JonWBedard JonWBedard JonWBedard approved these changes

@aj062 aj062 Awaiting requested review from aj062 aj062 is a code owner

@ryanhaddad ryanhaddad Awaiting requested review from ryanhaddad ryanhaddad is a code owner

@briannafan briannafan Awaiting requested review from briannafan briannafan is a code owner

Assignees

@chgibb-apple chgibb-apple

Labels
Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chgibb-apple @bls1999 @JonWBedard