Skip to content

Update wgslc to accept DeviceState configuration and pass it to WGSL::generate #46541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 25, 2025
Merged

Update wgslc to accept DeviceState configuration and pass it to WGSL::generate #46541

merged 1 commit into from
Jun 25, 2025

Conversation

jon-b-apple
Copy link
Contributor

@jon-b-apple jon-b-apple commented Jun 10, 2025 •
edited by webkit-early-warning-system
Loading

c72568f

Update wgslc to accept DeviceState configuration and pass it to WGSL::generate
https://bugs.webkit.org/show_bug.cgi?id=294255
rdar://152949492

Reviewed by Tadeu Zagallo and Mike Wyrzykowski.

Adopting new API introduced in https://bugs.webkit.org/show_bug.cgi?id=292945

* Source/WebGPU/WGSL/wgslc.cpp:
(printUsageStatement):
(CommandLine::shaderValidationEnabled const):
(CommandLine::appleGPUFamily const):
(CommandLine::parseArguments):
(runWGSL):

Canonical link: https://commits.webkit.org/296612@main

edd6a17

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
❌ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ⏳ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2   🛠 playstation
✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jun 10, 2025 •
edited
Loading

EWS run on current version of this PR (hash edd6a17)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
❌ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ⏳ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2   🛠 playstation
✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@tadeuzagallo tadeuzagallo added the merge-queue Applied to send a pull request to merge-queue label Jun 25, 2025
@jon-b-apple @tadeuzagallo
Update wgslc to accept DeviceState configuration and pass it to WGSL:…
c72568f 
…:generate

https://bugs.webkit.org/show_bug.cgi?id=294255
rdar://152949492

Reviewed by Tadeu Zagallo and Mike Wyrzykowski.

Adopting new API introduced in https://bugs.webkit.org/show_bug.cgi?id=292945

* Source/WebGPU/WGSL/wgslc.cpp:
(printUsageStatement):
(CommandLine::shaderValidationEnabled const):
(CommandLine::appleGPUFamily const):
(CommandLine::parseArguments):
(runWGSL):

Canonical link: https://commits.webkit.org/296612@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Update-wgslc-to-accept-DeviceState-configuration-and-pass-it-to-WGSL-generate branch from edd6a17 to c72568f Compare June 25, 2025 10:54
@webkit-commit-queue
Copy link
Collaborator

Committed 296612@main (c72568f): https://commits.webkit.org/296612@main

Reviewed commits have been landed. Closing PR #46541 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit c72568f into WebKit:main Jun 25, 2025
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jun 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tadeuzagallo tadeuzagallo tadeuzagallo approved these changes

@mwyrzykowski mwyrzykowski mwyrzykowski approved these changes

@djg djg Awaiting requested review from djg djg is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jon-b-apple @webkit-early-warning-system @webkit-commit-queue @tadeuzagallo @mwyrzykowski