Skip to content

Stress test of having many matchMedia instances. #46391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 28, 2025
Merged

Stress test of having many matchMedia instances. #46391

merged 1 commit into from
Jun 28, 2025
+36 −0

Conversation

mstyura
Copy link
Contributor

@mstyura mstyura commented Jun 5, 2025 •
edited by webkit-early-warning-system
Loading

0af29d2

Stress test of having many matchMedia instances.
https://bugs.webkit.org/show_bug.cgi?id=293538.

Reviewed by Darin Adler.

The test added demonstrates the overhead of
current implementation of MediaQueryEvaluator::evaluate
which is called during Page::updateRendering().

* PerformanceTests/CSS/ManyMatchMediaInstances.html: Added.

Canonical link: https://commits.webkit.org/296773@main

0b7ee13

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ⏳ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2   🛠 playstation
✅ 🛠 tv
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jun 5, 2025 •
edited
Loading

EWS run on current version of this PR (hash 0b7ee13)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ⏳ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2   🛠 playstation
✅ 🛠 tv
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@mstyura mstyura mentioned this pull request Jun 5, 2025
Open
@Ahmad-S792 Ahmad-S792 added the Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases label Jun 5, 2025
@mstyura
Copy link
Contributor Author

mstyura commented Jun 11, 2025

Hello @Ahmad-S792, could you please help with assigning the appropriate reviewers, because the PR currently seems stuck. Thanks a lot in advance!

@Ahmad-S792 Ahmad-S792 requested review from smfr, anttijk and mdubet June 11, 2025 14:26
darinadler
darinadler approved these changes Jun 28, 2025
View reviewed changes
Copy link
Member

@darinadler darinadler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should land this and get it into the tree. We can make the test even better but I don't see an argument for waiting further for review before committing this first version.

@darinadler darinadler added the merge-queue Applied to send a pull request to merge-queue label Jun 28, 2025
@mstyura @darinadler
Stress test of having many matchMedia instances.
0af29d2 
https://bugs.webkit.org/show_bug.cgi?id=293538.

Reviewed by Darin Adler.

The test added demonstrates the overhead of
current implementation of MediaQueryEvaluator::evaluate
which is called during Page::updateRendering().

* PerformanceTests/CSS/ManyMatchMediaInstances.html: Added.

Canonical link: https://commits.webkit.org/296773@main
@webkit-commit-queue webkit-commit-queue force-pushed the perf/ManyMatchMediaInstances branch from 0b7ee13 to 0af29d2 Compare June 28, 2025 20:29
@webkit-commit-queue
Copy link
Collaborator

Committed 296773@main (0af29d2): https://commits.webkit.org/296773@main

Reviewed commits have been landed. Closing PR #46391 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 0af29d2 into WebKit:main Jun 28, 2025
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jun 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darinadler darinadler darinadler approved these changes

@smfr smfr Awaiting requested review from smfr

@anttijk anttijk Awaiting requested review from anttijk

@mdubet mdubet Awaiting requested review from mdubet

Assignees

@mstyura mstyura

Labels
Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mstyura @webkit-early-warning-system @webkit-commit-queue @darinadler @Ahmad-S792