-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Refactor jitMemcpy into atomic and non-atomic versions #45969
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
justinmichaud
wants to merge
2
commits into
WebKit:main
Choose a base branch
from
justinmichaud:eng/Refactor-jitMemcpy-into-atomic-and-non-atomic-versions
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Refactor jitMemcpy into atomic and non-atomic versions #45969
justinmichaud
wants to merge
2
commits into
WebKit:main
from
justinmichaud:eng/Refactor-jitMemcpy-into-atomic-and-non-atomic-versions
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
EWS run on previous version of this PR (hash cbfdbee) |
EWS run on previous version of this PR (hash ef45cfd) |
EWS run on previous version of this PR (hash f04552a) |
https://bugs.webkit.org/show_bug.cgi?id=293649 Reviewed by NOBODY (OOPS!). On ARMv7, there are some concurrent repatching issues because of unaligned writes to the jit region. Instead of repatching whenever it is easy, we should be explicit about when we expect writes to the jit region to tear or not. We also add a new option to test this that forces tears in the non-atomic version. Finally, we increase the alignment on armv7 for patchable jumps.
f04552a
to
34e2af2
Compare
EWS run on previous version of this PR (hash 34e2af2) |
EWS run on current version of this PR (hash 172b2e6) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
JavaScriptCore
For bugs in JavaScriptCore, the JS engine used by WebKit, other than kxmlcore issues.
merging-blocked
Applied to prevent a change from being merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cbfdbee
172b2e6