Add contextual TKV signals to PA Explainer #1429
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Proposal to add contextual TKV signals that will only be sent to TEE-based servers. There are a couple ambiguities here that this PR proposes behavior for, but feedback would be much appreciated on. In particular: * Should time spent waiting on a unique per-bidder process count towards the bidder's cumulative timeout? We could allow this to be configured via the AuctionConfig, but of course, that's yet more complexity. * If the promise fails, what should we do? It seems simplest to not run generateBid() at all for that bidder, even for IGs that use v1 servers or have no signals request. This is because we likely will need to delay running those generateBid() calls until we have the contextual signals, anyways (to avoid either having to load the bidder twice, or keeping the bidder around, consuming out global process quota). We could alternatively provide no signals to the server and still send the request, or only make generateBid() calls for IGs that don't use a TEE-based TKV that can receive the data.
Fix typo.
Relax constraints on rejected promises
|
I've relaxed the behavior around other IGs for the same buyer that don't use a KVv2 signals URL - they're no longer affected by promise resolution being rejected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal to add contextual TKV signals that will only be sent to TEE-based servers.
There are a couple ambiguities here that this PR proposes behavior for, but feedback would be much appreciated on. In particular:
The current plan is to hold off on loading a bidder's script (and thus assigning a process, which we have a cap on) until the per-bidder promise is resolved. That could impact performance, but keeping a bidder process around while waiting on a promise to resolved is also a potential source of performance issues, including deadlock until a promise is resolved, if this is happening for enough buyers at once.