Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Storage.interestGroupAuctionNetworkRequestCreated Event returns array of IG auction IDs than informing the exact IG auction-id #1154

Open
pm-harshad-mane opened this issue Apr 26, 2024 · 3 comments
Open

Storage.interestGroupAuctionNetworkRequestCreated Event returns array of IG auction IDs than informing the exact IG auction-id #1154

pm-harshad-mane opened this issue Apr 26, 2024 · 3 comments

Comments

@pm-harshad-mane
Copy link

We are using Storage.interestGroupAuctionNetworkRequestCreated event to listen to gather information of KV calls.
Following is link for the documentation,
https://chromedevtools.github.io/devtools-protocol/tot/Storage/#event-interestGroupAuctionNetworkRequestCreated
Specifies which auctions a particular network fetch may be related to, and in what role. Note that it is not ordered with respect to Network.requestWillBeSent (but will happen before loadingFinished loadingFailed).

For each auction a separate KV call is triggered and a unique Network requestId is created but this event is returning an array of IG
auction-ids on the page than informing the exact IG auction id for which this KV call with given network request ID is made.

We need this for debuging, #937

Screenshot 2024-04-26 at 2 41 50 PM
@pm-harshad-mane pm-harshad-mane changed the title Storage.interestGroupAuctionNetworkRequestCreated returns array of IG auction IDs than informing the exact IG auction-id Storage.interestGroupAuctionNetworkRequestCreated Event returns array of IG auction IDs than informing the exact IG auction-id Apr 26, 2024
@morlovich
Copy link
Collaborator

So to be precise, this is the list of auctions using the worklet at the moment of the fetch. The signals can come from any combination of them (and we don't actually keep track of from which). Related, the worklet will fetch JS (and wasm) only once, so other auctions sharing them will reuse that fetch.

@pm-harshad-mane
Copy link
Author

pm-harshad-mane commented May 1, 2024 •
edited

Hi @morlovich ,
Worklets are typically static files, and they often serve as shared resources across multiple PAA instances. Therefore, it seems logical to return an array of auction IDs for Worklets.
However, KeyValue server calls are dynamic and can vary for each auction.
Hence, I suggest that the API distinguishes between Worklet and KeyValue calls and returns the specific auction ID for KeyValue calls instead of providing an array of auction IDs

@MattMenke2
Copy link
Contributor

There isn't a specific auction ID - requests from multiple auctions can be merged, if the parameters are all the same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@morlovich @pm-harshad-mane @MattMenke2