Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Top level seller timeout values aren't available to the component sellers #1059

Open
rsachdev9191 opened this issue Feb 27, 2024 · 5 comments

Comments

@rsachdev9191
Copy link

rsachdev9191 commented Feb 27, 2024

The SSPs/component sellers need to understand the top-level seller timeouts when developing the component auctionConfig, as these timeouts must be less than or equal to those of the top-level seller (or risk timing out).

Top level seller timeouts are not provided in an automated way via Chrome or other instrumentation. The component seller is unable to programmatically know this value when creating auctionConfigs.

@MattMenke2
Copy link
Contributor

Top-level seller timeouts don't currently apply to component sellers or buyers - they only affect the top-level auction (which means just the top-level seller's scoreAd()).

@rsachdev9191
Copy link
Author

@MattMenke2 I updated the description. Pl lmk if that doesn't make sense

@MattMenke2
Copy link
Contributor

"as these timeouts must be less than or equal to those of the top-level seller (or risk timing out).". The top-level seller's auctionConfig timeouts aren't applied to the component auction. I think, from offline conversation, you actually mean some non-PA timeout applied to the entire auction?

@rsachdev9191
Copy link
Author

Based on your comment, seems like the two timeout values aren't related. Is there another timeout value that is applied to the entire PA auction?

If the top level seller timeout is configured to be 50ms and the component seller configures the perbuyertimeout to be 1000ms, in the current scheme of things, will the top level auction not run until all generatebids and component seller's scoread are run i.e. 1000ms per ig, per ssp?

@MattMenke2
Copy link
Contributor

No, there's currently no timeout that can be applied to the entire auction. It might be nice to add one - then a result of a partially completed auction could be run, which aborting an auction won't let you do.

Which top-level seller timeout? There are 3 timeouts, currently:

  1. sellerTimeout. This only affects the execution time of each scoreAd() call. It doesn't affect scripts. It only affects the seller's own scripts (i.e., top-level auctionConfig doesn't affect component auctions).
  2. perBidderTimeout. This only affects the execution time of match buyers' generateBid() scripts. The top-level auction value has no effect, since that auction can have no bidders (unless there are no component auctions, of course).
  3. perBidderCumulativeTimeout. This again only applies to bidders in that auction, though it covers fetch times and time running scripts for individual auction.

I think it would be reasonable to consider adding more timeouts (e.g., whole auction timeout, script or signals fetch timeouts, etc) and/or make top-level auction timeouts apply to component auctions. If adding new timeouts we should try to figure out the minimum set that would help, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants