Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider validating buckets for auctionReportBuyers sum to valid value #1040

Open
alexmturner opened this issue Feb 16, 2024 · 1 comment
Open

Consider validating buckets for auctionReportBuyers sum to valid value #1040

alexmturner opened this issue Feb 16, 2024 · 1 comment

Comments

@alexmturner
Copy link
Contributor

Currently, each bucket for per-buyer latency and statistics reporting using Private Aggregation (i.e. auctionReportBuyers reporting) is generated via a sum of a value in auctionReportBuyerKeys and a bucket specified in auctionReportBuyers. Each of these values is validated to fit into a 128-bit unsigned integer, but the sum is not. This could lead to unintentional overflow.
@qingxinwu
Copy link
Collaborator

seems to be this todo in code? https://crsrc.org/c/third_party/blink/renderer/modules/ad_auction/navigator_auction.cc;drc=738f1250512a5e6ff8cacb6b36540cd50e8156d8;l=2065

But agreed that this needs to be validated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@qingxinwu @alexmturner