Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Spec] Window.close should do nothing #26

Closed
dtapuska opened this issue May 2, 2022 · 1 comment
Closed

[Spec] Window.close should do nothing #26

dtapuska opened this issue May 2, 2022 · 1 comment
Labels
specification Additions to specifications

Comments

@dtapuska
Copy link

dtapuska commented May 2, 2022

window.close() on a fenced frame shouldn't start the window closing steps.

Chromium had a bug where this was observable via window.closed() but it should likely do nothing an exit early before starting the closing steps.

See https://chromium-review.googlesource.com/c/chromium/src/+/3607497 for context (and a WPT test)
@shivanigithub shivanigithub added the specification Additions to specifications label Jun 23, 2022
@domfarolino
Copy link
Collaborator

Per https://html.spec.whatwg.org/#dom-window-close, the spec currently operates in terms of top-level traversables (aka "outermost" or "primary" frames), so spec-wise we're all set here actually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
specification Additions to specifications
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@domfarolino @dtapuska @shivanigithub