Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Say something about what eventTypes are valid #126

Open
jyasskin opened this issue Sep 28, 2023 · 4 comments
Open

Say something about what eventTypes are valid #126

jyasskin opened this issue Sep 28, 2023 · 4 comments

Comments

@jyasskin
Copy link
Member

https://wicg.github.io/fenced-frame/#dom-fenceevent-eventtype doesn't have any uses that say what values are expected to work in that field. There's one instance of "If event’s eventType is not "reserved.top_navigation", return.", which implies that systems are expected to recognize specific values, but I don't see any way for them to find specific values to recognize.
@shivanigithub
Copy link
Collaborator

The values are allowed to be arbitrary strings and "reserved.top_navigation" is currently the only keyword but more might be added in future.

@shivanigithub
Copy link
Collaborator

cc @gtanzer

@jyasskin
Copy link
Member Author

https://wicg.github.io/shared-storage/#reporting currently has "If a SharedStorageUrlWithMetadata object contains a non-empty reportingMetadata object in the form of a dictionary whose keys are eventTypes ...", which doesn't make sense if eventTypes aren't constrained in any way. That could be a bug in the shared-storage spec. (cc @pythagoraskitty)

But there are still some constraints. I see that the eventType is expected to be a key in the reporting url map, for example. It winds up being hard to read the spec if relationships like this aren't called out and instead require tracing values through several levels of algorithms.

@domfarolino
Copy link
Collaborator

which doesn't make sense if eventTypes aren't constrained in any way.

Eh, maybe? I mean the keys of that map could simply be DOMStrings which isn't "wrong". But yeah elaborating on the overall relationship of all of these would be nice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jyasskin @domfarolino @shivanigithub