Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Naming alignment with PCM #173

Closed
maudnals opened this issue Jul 6, 2021 · 3 comments
Closed

Naming alignment with PCM #173

maudnals opened this issue Jul 6, 2021 · 3 comments

Comments

@maudnals
Copy link
Contributor

maudnals commented Jul 6, 2021

Follow-up from PCM/#30: one attribute name isn't consistent across the Attribution Reporting spec and the PCM spec.

Has this one fallen through the cracks or is there a reason why they're different? Do they have to be named differently due to the difference in data limitations?

@maudnals maudnals changed the title Naming alignment with WebKit Naming alignment with PCM Jul 6, 2021
@abebis
Copy link

abebis commented Jul 7, 2021

Looking at the issue you linked it was intentional.

We would likely need another name for the low-entropy campaign ID.

and

{
  "source-engagement-type" : <string>, // click or view
  "source-site" : <string>,
  "source-id" : <int>, // for PCM
  "source-event-id" : <int>, // for CM-API
  "attributed-on" : <string>,
  "trigger-data" : <int>,
  "version": <int>
}

@csharrison did not mention the reason but I guess that if it was a common attribute developers would have to align with the stricter (PCM) version and use a low-entropy id even on Chrome?

@csharrison
Copy link
Collaborator

Yes this was intentional, because it avoids the need to do user agent sniffing to support both API versions. It may be possible to be clever and use one ID for both systems as long as the ID is properly truncated in PCM, but the current spec for PCM says that inserting a too-big value will cause the API to fail:
https://privacycg.github.io/private-click-measurement/#ref-for-dom-htmlanchorelement-attributionsourceid

Closing this out but Maud feel free to re-open if you have any other suggestions.

@maudnals
Copy link
Contributor Author

Great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants