fix(detox): resolve android connectivity issues #635
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1fd6ffe to
1532f49
Compare
- added stub for ReactNativeVersion - fixed issues preventing androidTest from being bundled into the test - bumped version to 1.0.2
1532f49 to
eed646b
Compare
|
Published in 1.0.2: 831cad1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves a key issue preventing Detox E2E tests from connecting to the app on Android.
The root causes identified were
com.facebook.react.modules.systeminfo.ReactNativeVersionwhich prevents the app from startingWhy it matters:
Without this fix, Detox hangs indefinitely trying to connect to the app, even though the test server and device are both correctly configured.
Potentially fixes #189