Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Change cms_medicare tables with column provider_zipcode from integer to string type #417

Merged
merged 3 commits into from
Jul 18, 2022

Conversation

nlarge-google
Copy link
Collaborator

@nlarge-google nlarge-google commented Jul 18, 2022

Description

Fixing data type integer on all zip-code fields to become string datatype.

Checklist

  • (Required) This pull request is appropriately labeled
  • Please merge this pull request after it's approved

Use the sections below based on what's applicable to your PR and delete the rest:

Data Onboarding

  • I'm adding or editing a dataset
  • The Google Cloud Datasets team is aware of the proposed dataset
  • I put all my code inside datasets/cms_medicare and nothing outside of that directory

@nlarge-google nlarge-google self-assigned this Jul 18, 2022
@adlersantos adlersantos added data onboarding Onboard a dataset or submit a pipeline bug Something isn't working or open a bugfix revision: pipeline Revise a pipeline or dataset and removed data onboarding Onboard a dataset or submit a pipeline labels Jul 18, 2022
Copy link
Member

@adlersantos adlersantos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Merge when tests pass.

@adlersantos adlersantos changed the title Fix: Change of datatype for zip codes from integer to string. Fix: Change cms_medicare tables with column provider_zipcode from integer to string type Jul 18, 2022
@nlarge-google nlarge-google merged commit 27b0a9b into GoogleCloudPlatform:main Jul 18, 2022
vijay-google pushed a commit to vijay-google/public-datasets-pipelines that referenced this pull request Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working or open a bugfix revision: pipeline Revise a pipeline or dataset
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants