Feat: Onboard Fashion MNIST dataset #387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
happyhuman
reviewed
Jun 17, 2022
| ) | ||
|
|
||
| ( | ||
| download_and_process_source_zip_file |
There was a problem hiding this comment.
Can we use a different naming convention for these nodes, other than using _2, _3, _4? Maybe a descriptive name of what each node does?
adlersantos
requested changes
Jun 22, 2022
There was a problem hiding this comment.
No need for KPods, just use the Bash operator to download the files into the Composer bucket via the local Airflow directory, then copy to the destination bucket.
See here for an explanation: https://cloud.google.com/composer/docs/concepts/cloud-storage
nlarge-google
approved these changes
Jul 11, 2022
nlarge-google
approved these changes
Jul 11, 2022
adlersantos
approved these changes
Jul 11, 2022
vijay-google
pushed a commit
to vijay-google/public-datasets-pipelines
that referenced
this pull request
Aug 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Pipelines included:
Checklist
Note: If an item applies to you, all of its sub-items must be fulfilled
fashion_mnist/<fashion_mnist>and nothing outside of that directory