Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: YAML custom tag for interpolating GCR image URLs #372

Merged

Conversation

alick-at-google
Copy link
Contributor

@alick-at-google alick-at-google commented Jun 2, 2022

Description

Note: If you are adding or editing a dataset, please specify the dataset folder involved, e.g. datasets/google_trends

Checklist

Note: If an item applies to you, all of its sub-items must be fulfilled

  • (Required) This pull request is appropriately labeled
  • Please merge this pull request after it's approved
  • I'm adding or editing a feature
    • I have added tests for the feature
  • I'm refactoring or cleaning up some code

@alick-at-google alick-at-google changed the title feat: add customer yaml constructor feat: add customyaml constructor Jun 2, 2022
@alick-at-google alick-at-google changed the title feat: add customyaml constructor feat: add custom yaml constructor Jun 2, 2022
@adlersantos adlersantos self-requested a review June 16, 2022 19:03
@adlersantos adlersantos added the feature request New feature or request label Jun 16, 2022
@adlersantos adlersantos added the cleanup Cleanup or refactor code label Aug 16, 2022
@adlersantos adlersantos changed the title feat: add custom yaml constructor feat: YAML custom tag for interpolating GCR image URLs Aug 16, 2022
Copy link
Collaborator

@nlarge-google nlarge-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Job!

@nlarge-google nlarge-google merged commit ef901e5 into GoogleCloudPlatform:main Aug 17, 2022
vijay-google pushed a commit to vijay-google/public-datasets-pipelines that referenced this pull request Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Cleanup or refactor code feature request New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants