Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Retrieve Composer bucket name when deploying DAGs #312

Merged
merged 10 commits into from
Apr 8, 2022
Merged

feat: Retrieve Composer bucket name when deploying DAGs #312

merged 10 commits into from
Apr 8, 2022

Conversation

arjunsgill
Copy link
Contributor

Description

Note: If you are adding or editing a dataset, please specify the dataset folder involved, e.g. datasets/google_trends

  • tidied up readme, to make it more consistent remove $ in the beginning some of the bash scripts
  • added a function to automatically retrieve the gcs bucket via the composer api if it is not specified

Checklist

Note: If an item applies to you, all of its sub-items must be fulfilled

  • (Required) This pull request is appropriately labeled
  • I'm adding/editing documentation
  • I'm refactoring or cleaning up some code

@arjunsgill arjunsgill changed the title added function to retrieve composer gcs bucket without it being specified and updated readme Fix: added function to retrieve composer gcs bucket without it being specified and updated readme Mar 21, 2022
@arjunsgill arjunsgill changed the title Fix: added function to retrieve composer gcs bucket without it being specified and updated readme feat: added function to retrieve composer gcs bucket without it being specified and updated readme Mar 21, 2022
@adlersantos adlersantos self-requested a review March 24, 2022 14:17
@adlersantos adlersantos changed the title feat: added function to retrieve composer gcs bucket without it being specified and updated readme feat: Retrieve Composer bucket without it being required when deploying DAGs Mar 25, 2022
adlersantos
adlersantos requested changes Mar 31, 2022
View reviewed changes
Copy link
Member

@adlersantos adlersantos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor changes but overall LGTM!

Pipfile Outdated Show resolved Hide resolved
Pipfile Outdated Show resolved Hide resolved
scripts/deploy_dag.py Outdated Show resolved Hide resolved
@adlersantos adlersantos changed the title feat: Retrieve Composer bucket without it being required when deploying DAGs feat: Retrieve Composer bucket name when deploying DAGs Apr 8, 2022
@adlersantos adlersantos merged commit 220f1d5 into GoogleCloudPlatform:main Apr 8, 2022
@release-please release-please bot mentioned this pull request Apr 8, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adlersantos adlersantos adlersantos approved these changes

@leahecole leahecole Awaiting requested review from leahecole

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@arjunsgill @adlersantos