Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Onboard SEC Failure to Deliver dataset #309

Merged
merged 19 commits into from
Apr 4, 2022
Merged

Feat: Onboard SEC Failure to Deliver dataset #309

merged 19 commits into from
Apr 4, 2022

Conversation

nlarge-google
Copy link
Collaborator

@nlarge-google nlarge-google commented Mar 16, 2022 •
edited

Checklist

Note: If an item applies to you, all of its sub-items must be fulfilled

  • (Required) This pull request is appropriately labeled
  • Please merge this pull request after it's approved
  • I'm adding or editing a dataset
    • The Google Cloud Datasets team is aware of the proposed dataset
    • I put all my code inside datasets/sec_failure_to_deliver and nothing outside of that directory
      pipelines/tree/main/tests) folder)
  • I'm refactoring or cleaning up some code

nlarge-google and others added 12 commits December 8, 2021 21:50
@nlarge-google
fix: Accidental check-in resolved
ba4bff6
@nlarge-google
Merge remote-tracking branch 'upstream/main'
2151001
@nlarge-google
Merge branch 'GoogleCloudPlatform:main' into main
f29a843
@nlarge-google
Merge remote-tracking branch 'upstream/main'
7d9347a
@nlarge-google
Merge remote-tracking branch 'upstream/main'
46dcd54
@nlarge-google
Merge branch 'GoogleCloudPlatform:main' into main
8594162
@nlarge-google
fix: Re-engineered due to memory pressure with original version. Not …
b0082d3 
…production ready
@nlarge-google
fix: Re-engineered and resolving source file consistency and formatti…
3d820c3 
…ng issues.
@nlarge-google
fix: Re-engineered and resolving source file consistency and formatti…
0234d69 
…ng issues - ctd.
@nlarge-google
fix: Re-engineered and resolving source file consistency and formatti…
12ea877 
…ng issues - ctd.
@nlarge-google
fix: Re-engineered and resolving source file consistency and formatti…
1c5a2a0 
…ng issues - ctd.
@nlarge-google
fix: Completed and tested in AF. Ready for code review
25e44e0
@nlarge-google nlarge-google self-assigned this Mar 16, 2022
@nlarge-google
Copy link
Collaborator Author

@adlersantos @happyhuman This is a re-engineer of vasu's code in #260 (review). The code has been completely re-engineered and tested in AF. Please review. Thanks!

@nlarge-google nlarge-google mentioned this pull request Mar 16, 2022
Closed
4 tasks
@nlarge-google
Copy link
Collaborator Author

@happyhuman @adlersantos Please review the changes I have made as-per the code review. Thanks.

@nlarge-google
Copy link
Collaborator Author

@adlersantos @happyhuman Please ignore LINT errors. Please review. Thanks!

@nlarge-google
Copy link
Collaborator Author

@happyhuman @adlersantos Lint issues are now resolved. Please review! Thanks.

@adlersantos adlersantos changed the title Feat: Onboard sec failure to deliver Feat: Onboard SEC Failure to Deliver dataset Apr 4, 2022
@adlersantos adlersantos merged commit afa6492 into GoogleCloudPlatform:main Apr 4, 2022
@release-please release-please bot mentioned this pull request Apr 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@happyhuman happyhuman happyhuman left review comments

@adlersantos adlersantos adlersantos approved these changes

Assignees

@nlarge-google nlarge-google

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nlarge-google @adlersantos @happyhuman