Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Onboarding TheLook E-Commerce dataset #294

Merged
merged 22 commits into from
Feb 28, 2022
Merged

feat: Onboarding TheLook E-Commerce dataset #294

merged 22 commits into from
Feb 28, 2022

Conversation

alick-at-google
Copy link
Contributor

@alick-at-google alick-at-google commented Feb 11, 2022 •
edited by adlersantos

Description

Note: If you are adding or editing a dataset, please specify the dataset folder involved, e.g. datasets/google_trends

Checklist

Note: If an item applies to you, all of its sub-items must be fulfilled

  • (Required) This pull request is appropriately labeled
  • Please merge this pull request after it's approved
  • I'm adding or editing a feature
    • I have updated the README accordingly
    • I have added tests for the feature
  • I'm adding or editing a dataset
    • The Google Cloud Datasets team is aware of the proposed dataset
    • I put all my code inside datasets/<DATASET_NAME> and nothing outside of that directory
  • I'm adding/editing documentation
  • I'm submitting a bugfix
    • I have added tests to my bugfix (see the tests folder)
  • I'm refactoring or cleaning up some code

@adlersantos adlersantos added the data onboarding Onboard a dataset or submit a pipeline label Feb 11, 2022
@leahecole leahecole requested review from leahecole and removed request for leahecole February 11, 2022 20:51
@adlersantos adlersantos merged commit 15f663a into GoogleCloudPlatform:main Feb 28, 2022
@release-please release-please bot mentioned this pull request Feb 28, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adlersantos adlersantos adlersantos approved these changes

@happyhuman happyhuman Awaiting requested review from happyhuman

@leahecole leahecole Awaiting requested review from leahecole

Assignees
No one assigned
Labels
data onboarding Onboard a dataset or submit a pipeline
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alick-at-google @adlersantos