Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add region property for CloudBuildTrigger Resource #672

Closed
3 tasks done
travisrandolph-bestbuy opened this issue Jun 21, 2022 · 7 comments
Closed
3 tasks done

Add region property for CloudBuildTrigger Resource #672

travisrandolph-bestbuy opened this issue Jun 21, 2022 · 7 comments
Labels
enhancement New feature or request

Comments

@travisrandolph-bestbuy
Copy link

Checklist

  • I did not find a related open enhancement request.
  • I understand that enhancement requests filed in the GitHub repository are by default low priority.
  • If this request is time-sensitive, I have submitted a corresponding issue with GCP support.

Describe the feature or resource

The Cloud Build trigger API now supports region. We'd like to have this option for our KCC resources.

Additional information

No response

Importance

This isn't a blocker, but currently our triggers and history pages don't match up. This is due to the fact that we are using custom worker pools that are in another region. If KCC supports the region property for CloudBuildTriggers we can change the region to match.

@travisrandolph-bestbuy travisrandolph-bestbuy added the enhancement New feature or request label Jun 21, 2022
@mbzomowski
Copy link

Hi @travisrandolph-bestbuy, would you mind providing a link to the REST API documentation you're looking at? I checked https://cloud.google.com/build/docs/api/reference/rest/v1/projects.triggers and couldn't find any mention of a region field.

@travisrandolph-bestbuy
Copy link
Author

I can't find the field either, but you can update the region via the console. I've added a screenshot showing the field.

trigger

@travisrandolph-bestbuy
Copy link
Author

@mbzomowski after digging into this further I think this is the API being used. There you can see location in the trigger name.

@caieo
Copy link
Contributor

caieo commented Aug 19, 2022

@travisrandolph-bestbuy, thank you for the request! Since your request is to support a new feature in one of our Terraform-based resources,
can you file an enhancement request with Terraform (if there isn't one yet)?

Note that timelines for Terraform resource requests can be pretty unpredictable. We recommend making the contribution yourself if possible (which we would also highly appreciate!).
Otherwise, we'll keep you posted on updates.

If you have other concerns or would like to escalate this request, please feel free to reach out to GCP support.

@travisrandolph-bestbuy
Copy link
Author

@caieo it looks like this issue was created to add support for location. It looks like the pull request with the change was just merged.

@mbzomowski
Copy link

@travisrandolph-bestbuy after they create a release with that change we'll upgrade our TF provider, and do a Config Connector release the week after that. Should be about 4 weeks FYI.

@mbzomowski
Copy link

location field is now included in CloudBuildTrigger as of Config Connector v 1.96.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants