Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support resource names overrides outside of K8s allowed character range #128

Closed
reubenvanammers opened this issue Mar 31, 2020 · 9 comments
Labels
enhancement New feature or request

Comments

@reubenvanammers
Copy link

Currently, as kubernetes only allows dashes in the name, not underscores, and Bigquery table names only allow underscores, not dashes, it is impossible to use a separator (underscore/dash/space etc) when creating a table.

An obvious fix would be to convert all dashes to underscores when creating a table.

@maqiuyujoyce
Copy link
Collaborator

@reubenvanammers Thank you for your feedback. We will look into being able to specify the resource ID in the spec and will let you know when we have more information.

@maqiuyujoyce maqiuyujoyce added the enhancement New feature or request label Apr 1, 2020
@AlexBulankou
Copy link
Contributor

K8s limits character set to a-z0-9?

@AlexBulankou AlexBulankou changed the title Cannot create tables with an underscore in their name Support resource names overrides outside of K8s allowed character range May 22, 2020
@max-sixty
Copy link

Here's an example:

bigquerydataset.bigquery.cnrm.cloud.google.com/x unchanged

The BigQueryDataset "x_y" is invalid: metadata.name: Invalid value: "x_y": a 
DNS-1123 subdomain must consist of lower case alphanumeric characters, 
'-' or '.', and must start and end with an alphanumeric character (e.g. 'example.com', 
regex used for validation is 
'[a-z0-9]([-a-z0-9]*[a-z0-9])?(\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*')

Is there any workaround?

Tangentially related: #112

@maqiuyujoyce
Copy link
Collaborator

maqiuyujoyce commented May 30, 2020

@max-sixty thank you for the additional details. Unfortunately, "-" or "_" can't be used in the BigQuery table or dataset names in KCC right now. We are looking into supporting the feature to specify the resource ID in the spec, and with that feature, users can specify BigQuery resource names with "_" in it. Will keep you updated if we have more information.

@kibbles-n-bytes
Copy link
Contributor

@AlexBulankou From https://kubernetes.io/docs/concepts/overview/working-with-objects/names/#dns-subdomain-names :

Most resource types require a name that can be used as a DNS subdomain name as defined in RFC 1123. This means the name must:

  • contain no more than 253 characters
  • contain only lowercase alphanumeric characters, ‘-’ or ‘.’
  • start with an alphanumeric character
  • end with an alphanumeric character

@RoryShively
Copy link

Is there a timeline on this? I was told it would be worked on during Q3

@maqiuyujoyce
Copy link
Collaborator

Hi @RoryShively , we're currently working on supporting resource name overrides and should have the feature out around the end of October.

@flunderpero
Copy link

I am having the same issue with Storage bucket names and KMS keys (as a policy we use underscore everywhere if possible and only fall back to dash in Kubernetes) while trying to convert our configuration management to Cloud Configuration.

@toumorokoshi
Copy link
Contributor

closing as a duplicate of #25 (doing some light cleanup). Please watch that issue.

As mentioned, we plan on providing a new field which isn't subject to k8s naming restrictions to specify the GCP resource name. The current ETA is by first week of January.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

8 participants