Skip to content

doc: examples use declarative configuration 4/N #370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 4, 2023
Merged

doc: examples use declarative configuration 4/N #370

merged 1 commit into from
Jul 4, 2023

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Jul 4, 2023

Part of the work for #345

@codecov
Copy link

codecov bot commented Jul 4, 2023

Codecov Report

Merging #370 (688bc44) into main (6a9c412) will increase coverage by 0.11%.
The diff coverage is 100.00%.

❗ Current head 688bc44 differs from pull request most recent head da0c9d9. Consider uploading reports for the commit da0c9d9 to get more accurate results

@@            Coverage Diff             @@
##             main     #370      +/-   ##
==========================================
+ Coverage   88.96%   89.07%   +0.11%     
==========================================
  Files          97       97              
  Lines        3044     3076      +32     
==========================================
+ Hits         2708     2740      +32     
  Misses        336      336
Impacted Files Coverage Δ
examples/site/env_vars/env_vars.cc 100.00% <100.00%> (ø)
...amples/site/hello_world_error/hello_world_error.cc 100.00% <100.00%> (ø)
examples/site/hello_world_get/hello_world_get.cc 100.00% <100.00%> (ø)
examples/site/http_content/http_content.cc 97.91% <100.00%> (+0.04%) ⬆️
examples/site/http_cors/http_cors.cc 100.00% <100.00%> (ø)
examples/site/http_cors_auth/http_cors_auth.cc 100.00% <100.00%> (ø)
examples/site/http_form_data/http_form_data.cc 100.00% <100.00%> (ø)
examples/site/http_method/http_method.cc 100.00% <100.00%> (ø)
examples/site/http_xml/http_xml.cc 100.00% <100.00%> (ø)
examples/site/log_helloworld/log_helloworld.cc 100.00% <100.00%> (ø)
... and 1 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@coryan coryan marked this pull request as ready for review July 4, 2023 20:32
@coryan coryan requested a review from a team as a code owner July 4, 2023 20:32
@coryan coryan merged commit 63312c2 into GoogleCloudPlatform:main Jul 4, 2023
@coryan coryan deleted the doc-declarative-examples-pr4 branch July 4, 2023 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devbww devbww devbww approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@coryan @devbww