Skip to content

doc: examples use declarative configuration 1/N #356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 22, 2022
Merged

doc: examples use declarative configuration 1/N #356

merged 5 commits into from
Mar 22, 2022

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Mar 21, 2022

This is the first in a series of PRs to convert all examples to use
declarative configuration for the signature type.

Part of the work for #345

This is the first in a series of PRs to convert all examples to use
declarative configuration for the signature type.
@codecov
Copy link

codecov bot commented Mar 21, 2022

Codecov Report

Merging #356 (9f4d9b6) into main (498a3aa) will increase coverage by 0.08%.
The diff coverage is 98.24%.

❗ Current head 9f4d9b6 differs from pull request most recent head 287f17b. Consider uploading reports for the commit 287f17b to get more accurate results

@@            Coverage Diff             @@
##             main     #356      +/-   ##
==========================================
+ Coverage   89.26%   89.35%   +0.08%     
==========================================
  Files          98       98              
  Lines        2739     2761      +22     
==========================================
+ Hits         2445     2467      +22     
  Misses        294      294              
Impacted Files Coverage Δ
examples/hello_cloud_event/hello_cloud_event.cc 80.00% <80.00%> (+5.00%) ⬆️
examples/cloud_event_examples_test.cc 100.00% <100.00%> (ø)
...mples/hello_from_namespace/hello_from_namespace.cc 100.00% <100.00%> (ø)
...om_nested_namespace/hello_from_nested_namespace.cc 100.00% <100.00%> (ø)
...s/hello_multiple_sources/hello_multiple_sources.cc 100.00% <100.00%> (ø)
...s/hello_with_third_party/hello_with_third_party.cc 100.00% <100.00%> (ø)
examples/hello_world/hello_world.cc 100.00% <100.00%> (ø)
...les/howto_use_legacy_code/howto_use_legacy_code.cc 100.00% <100.00%> (ø)
examples/http_examples_test.cc 100.00% <100.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 498a3aa...287f17b. Read the comment docs.

@coryan coryan marked this pull request as ready for review March 22, 2022 14:37
@coryan coryan requested a review from a team as a code owner March 22, 2022 14:37
@coryan coryan merged commit fead12b into GoogleCloudPlatform:main Mar 22, 2022
@coryan coryan deleted the doc-declarative-examples-pr1 branch March 22, 2022 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants