Skip to content
This repository was archived by the owner on Mar 14, 2024. It is now read-only.

allow listitems to live in menu (fix #7802) #7803

Merged
merged 3 commits into from
Aug 24, 2022

Conversation

FMJansen
Copy link
Contributor

@FMJansen FMJansen commented Apr 27, 2022

List items are also allowed to exist within a menu element, which is now updated in axe-core.

Fixes #7802

Changes proposed in this pull request:

  • add to the list of elements in which a listitem can exist

List items are also allowed to exist within a menu element, which is now updated in axe-core.
@chrome-devrel-review-bot
Copy link
Collaborator

Hello! This is an automated review by our custom reviewbot. It updates automatically when code or GitHub comments in this pull request are created or updated.

Requested changes

If there are any common problems with the content files you created or modified, they will be listed here.

src/site/content/en/lighthouse-accessibility/listitem/index.md

  • Please change your usage of the following words:
    • Do not use master. Affected lines: 39

@FMJansen
Copy link
Contributor Author

Concerning the devrel-review-bot: GoogleChrome/lighthouse#13925

@stale
Copy link

stale bot commented Jul 30, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. To prevent this from happening, leave a comment.

@stale stale bot added stale and removed stale labels Jul 30, 2022
@FMJansen
Copy link
Contributor Author

This change is still needed, I think by now Chrome has updated, too.

@matthiasrohmer matthiasrohmer requested review from a team, rachelandrew and alexandrascript and removed request for a team August 18, 2022 08:56
@matthiasrohmer matthiasrohmer added the content Issues related to content label Aug 18, 2022
Copy link
Contributor

@alexandrascript alexandrascript left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % changes.

@matthiasrohmer matthiasrohmer merged commit b015bcd into GoogleChrome:main Aug 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
content Issues related to content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

content: Allow li items in menu element
4 participants