Skip to content

misc(build): shim unneeded deps in lr report generator #14773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 9, 2023
Merged

misc(build): shim unneeded deps in lr report generator #14773

merged 1 commit into from
Feb 9, 2023

Conversation

connorjclark
Copy link
Collaborator

@connorjclark connorjclark commented Feb 9, 2023 •
edited by paulirish
Loading

6c04777 changed the report generator to es modules, which for some reason results in rollup still including dependencies that had been DCE'd via rollupPlugins.removeModuleDirCalls. This PR explicitly shims the unneeded modules.

delta:

2,3c2,3
<   typeof exports === 'object' && typeof module !== 'undefined' ? factory(exports, require('module'), require('url'), require('path')) :
<   typeof define === 'function' && define.amd ? define(['exports', 'module', 'url', 'path'], factory) :
---
>   typeof exports === 'object' && typeof module !== 'undefined' ? factory(exports) :
>   typeof define === 'function' && define.amd ? define(['exports'], factory) :

Edit: previously: #13416 #14031 #14098 #14258

@connorjclark connorjclark requested a review from a team as a code owner February 9, 2023 18:47
@connorjclark connorjclark requested review from adamraine and removed request for a team February 9, 2023 18:47
@connorjclark connorjclark merged commit 106a963 into main Feb 9, 2023
@connorjclark connorjclark deleted the fix-lr-bundle branch February 9, 2023 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulirish paulirish paulirish approved these changes

@adamraine adamraine Awaiting requested review from adamraine adamraine is a code owner automatically assigned from GoogleChrome/lighthouse-hackers

Assignees

@adamraine adamraine

Labels
10.0 waiting4reviewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@connorjclark @paulirish @adamraine @devtools-bot