Skip to content

core: disconnect Puppeteer when started by Lighthouse #14770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 9, 2023
Merged

core: disconnect Puppeteer when started by Lighthouse #14770

merged 2 commits into from
Feb 9, 2023

Conversation

adamraine
Copy link
Member

Fixes #14769

@adamraine adamraine requested a review from a team as a code owner February 9, 2023 00:13
@adamraine adamraine requested review from connorjclark and removed request for a team February 9, 2023 00:13
@connorjclark
Copy link
Collaborator

Confirmed CLI doesn't hang now.

However, the tab remains open. Is that what we want?

@adamraine
Copy link
Member Author

However, the tab remains open. Is that what we want?

Probably not. If we opened the tab then we should close it as well. If a user wants to reuse the tab they should set it up with Puppeteer themselves and be responsible for closing it.

@connorjclark connorjclark merged commit 89d9fb5 into main Feb 9, 2023
@connorjclark connorjclark deleted the fr-disconnect-browser branch February 9, 2023 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@connorjclark connorjclark connorjclark approved these changes

Assignees

@connorjclark connorjclark

Labels
waiting4reviewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New navigation flow doesn't exit test with existing browser.
3 participants
@adamraine @connorjclark @devtools-bot