Skip to content

core(config): prevent custom gatherer interference #14756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 8, 2023

Conversation

adamraine
Copy link
Member

I noticed a relatively serious issue when testing a config with a custom gatherer. We always run the gatherer after all our default config gatherers which means that FullPageScreenshot and BFCacheFailures can mess with any instrumentation or results that the custom gatherer is using.

This PR adds an internal priority factor that we can use to sort artifacts so that custom gatherers will run always run before FullPageScreenshot and BFCacheFailures.

It might be useful to add this priority factor to the config so it isn't so subtle, but I wanted to avoid new config spec changes this late into the process.

Some other ideas:

  • Tell people to use usePassiveGathering: true if they have a custom gatherer
  • Instead of doing a priority factor, add an isDestructive flag

@adamraine adamraine changed the title WIP: prevent custom gatherer interference core(config): prevent custom gatherer interference Feb 7, 2023
@adamraine adamraine marked this pull request as ready for review February 7, 2023 18:14
@adamraine adamraine requested a review from a team as a code owner February 7, 2023 18:14
@adamraine adamraine requested review from brendankenny and removed request for a team February 7, 2023 18:14
@connorjclark connorjclark merged commit 017ad4e into main Feb 8, 2023
@connorjclark connorjclark deleted the prevent-custom-gatherer-interference branch February 8, 2023 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants