Skip to content

report(flow): disable sticky table header #14748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 6, 2023
Merged

Conversation

adamraine
Copy link
Member

Fixes #14519

@adamraine adamraine requested a review from a team as a code owner February 3, 2023 21:23
@adamraine adamraine requested review from brendankenny and removed request for a team February 3, 2023 21:23
@@ -280,6 +281,11 @@
--section-padding-vertical: 8px;
}

.lh-container:not(.lh-topbar + .lh-container) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worth noting this is "just for flow reports"?

double checked that PSI still has a lh-container (it does).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically it's any renderer that passes omitTopbar: true so I don't think it's worth making a comment about how this is specific to flows.

@adamraine adamraine merged commit 56d62a6 into main Feb 6, 2023
@adamraine adamraine deleted the flow-disable-sticky-table branch February 6, 2023 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sticky table header is bugged on the flow report
4 participants