core(bf-cache-failures): pause on the temporary page #14694
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a DIFFERENT e2e test failure btw: I haven't reproed this one yet. Frustration levels increasing. |
connorjclark
approved these changes
Jan 20, 2023
brendankenny
reviewed
Feb 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately, this is the best solution I could get to while investigating the recent e2e test failures. I haven't seen it fail with this timeout yet but obviously not a guarantee. IMO this should at least reduce the flakiness.
I experimented with
waitForCPUIdleinstead butRuntime.evaluatewill throw an error similar toPage.navigateToHistoryEntry.