docs: update web.dev links to new developer.chrome.com home #14581
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brendankenny
commented
Dec 2, 2022
Comment on lines
-135
to
-136
| The [windowing | ||
| adjustment](https://www.google.com/url?q=https://web.dev/evolving-cls/&sa=D&source=editors&ust=1622570731600000&usg=AOvVaw2R7Y5uFrQX7Mpdj__5SdYq) |
There was a problem hiding this comment.
not sure how we missed these :)
adamraine
approved these changes
Dec 2, 2022
| @@ -17,7 +17,7 @@ const UIStrings = { | |||
| title: 'Preload Largest Contentful Paint image', | |||
| /** Description of a lighthouse audit that tells a user to preload an image in order to improve their LCP time. */ | |||
| description: 'If the LCP element is dynamically added to the page, you should preload the ' + | |||
| 'image in order to improve LCP. [Learn more about preloading LCP elements](https://web.dev/optimize-lcp/#preload-important-resources).', | |||
| 'image in order to improve LCP. [Learn more about preloading LCP elements](https://web.dev/optimize-lcp/#optimize-when-the-resource-is-discovered).', | |||
There was a problem hiding this comment.
Are we gong to create our own doc for this as part of #13738?
| @@ -24,7 +24,7 @@ const UIStrings = { | |||
| failureTitle: 'Page is blocked from indexing', | |||
| /** Description of a Lighthouse audit that tells the user *why* allowing search-engine crawling of their page is beneficial. This is displayed after a user expands the section to see more. No character length limits. The last sentence starting with 'Learn' becomes link text to additional documentation. */ | |||
| description: 'Search engines are unable to include your pages in search results ' + | |||
| 'if they don\'t have permission to crawl them. [Learn more about crawler directives](https://web.dev/is-crawable/).', | |||
There was a problem hiding this comment.
Ha, well spotted. I was confused at first how it worked at all (turns out GoogleChrome/web.dev#5407 added a redirect) and then worried for a second that we had our audit ID wrong all this time.
connorjclark
approved these changes
Dec 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update remainder of web.dev docs links to new https://developer.chrome.com/docs/lighthouse/ home
Related Issues/PRs
#14400