Skip to content

deps: upgrade third-party-web to 0.20.2 #14546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 1, 2022
Merged

deps: upgrade third-party-web to 0.20.2 #14546

merged 2 commits into from
Dec 1, 2022

Conversation

alexnj
Copy link
Member

@alexnj alexnj commented Nov 17, 2022

No description provided.

@connorjclark
Copy link
Collaborator

connorjclark commented Nov 18, 2022

Is the delta in sample json expected? May need to tweak the sample artifacts to restore some failing audit result there.

@alexnj
Copy link
Member Author

alexnj commented Nov 18, 2022

No, the delta exists due to the entity not being recognized. It should be recognized, hence #14548.

@alexnj
Copy link
Member Author

alexnj commented Nov 18, 2022

Alternatively, if we choose to not recognize the ~1040 entities that are missing due to not being present in HTTPArchive-data set, I'll go ahead update the sample json.

@connorjclark
Copy link
Collaborator

let's land #14548 first, and hopefully get the sample json to not lose data

@alexnj alexnj merged commit 7164f11 into main Dec 1, 2022
@alexnj alexnj deleted the 3pweb-0.20 branch December 1, 2022 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants