Skip to content

core(fr): always run NetworkUserAgent gatherer #14392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 16, 2022
Merged

core(fr): always run NetworkUserAgent gatherer #14392

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bf2d5fc
core(fr): always run NetworkUserAgent gatherer
adamraine Sep 15, 2022
246e8f8
ope
adamraine Sep 15, 2022
a4f6412
filter
adamraine Sep 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions cli/test/cli/__snapshots__/index-test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,10 @@ Object {
"gatherer": "trace",
"id": "Trace",
},
Object {
"gatherer": "network-user-agent",
"id": "NetworkUserAgent",
},
Object {
"gatherer": "stacks",
"id": "Stacks",
Expand Down Expand Up @@ -140,6 +144,7 @@ Object {
"artifacts": Array [
"DevtoolsLog",
"Trace",
"NetworkUserAgent",
"Stacks",
"devtoolsLogs",
"traces",
Expand Down
3 changes: 2 additions & 1 deletion core/fraggle-rock/config/filters.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,8 @@ const filterResistantAuditIds = ['full-page-screenshot'];

// Some artifacts are used by the report for additional information.
// Always run these artifacts even if audits do not request them.
const filterResistantArtifactIds = ['HostUserAgent', 'HostFormFactor', 'Stacks', 'GatherContext'];
// These are similar to base artifacts but they cannot be run in all 3 modes.
const filterResistantArtifactIds = ['Stacks', 'NetworkUserAgent'];

/**
* Returns the set of audit IDs used in the list of categories.
Expand Down