Skip to content

core(smoke): replace --invert-match cli option with --ignore-exclusions #14332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 2, 2022
Merged

core(smoke): replace --invert-match cli option with --ignore-exclusions #14332

merged 5 commits into from
Sep 2, 2022

Conversation

alexnj
Copy link
Member

@alexnj alexnj commented Aug 30, 2022

Fixes #14328.

  1. Retires the --invert-match smoke CLI option that's no longer adding any value.
  2. Adds a new --ignore-exclusions option to save the trouble of editing exclusions config to run a disabled test locally.

@alexnj alexnj requested a review from brendankenny August 30, 2022 19:06
@alexnj alexnj requested a review from a team as a code owner August 30, 2022 19:06
brendankenny
brendankenny approved these changes Aug 31, 2022
View reviewed changes
Copy link
Contributor

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexnj alexnj merged commit 4155faf into GoogleChrome:master Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brendankenny brendankenny brendankenny approved these changes

@adamraine adamraine adamraine approved these changes

Assignees

@brendankenny brendankenny

Labels
waiting4reviewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

smoke: retire --invert-match cli option
4 participants
@alexnj @brendankenny @adamraine @devtools-bot