Skip to content

deps: update to latest CDT packages #14293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 15, 2022
Merged

Conversation

adamraine
Copy link
Member

Fixes #14284

@adamraine adamraine requested a review from a team as a code owner August 15, 2022 16:50
@adamraine adamraine requested review from connorjclark and removed request for a team August 15, 2022 16:50
@adamraine adamraine changed the title misc: pull deprecations strings deps: pull latest CDT libs Aug 15, 2022
@connorjclark connorjclark changed the title deps: pull latest CDT libs deps: update to latest CDT packages Aug 15, 2022
@adamraine adamraine merged commit 6490ae9 into master Aug 15, 2022
@adamraine adamraine deleted the pull-deprecations-strings branch August 15, 2022 18:11
alexnj pushed a commit to alexnj/lighthouse that referenced this pull request Aug 24, 2022
@Generosus
Copy link

Hey Guys,

Apologies for tuning in late, but is this issue resolved?

Lighthouse (Best Practices Module) is still penalizing us for using Expect-CT in our header. When we remove Expect-CT from our header, the issue is fixed.

We're using Lighthouse Version 100.0.0.0.

Thank you!

@adamraine
Copy link
Member Author

Lighthouse (Best Practices Module) is still penalizing us for using Expect-CT in our header. When we remove Expect-CT from our header, the issue is fixed.

This is WAI. The Expect-CT header has been deprecated in Chrome. From the deprecation message:

"The Expect-CT header is deprecated and will be removed. Chrome requires Certificate Transparency for all publicly trusted certificates issued after April 30, 2018."

@Generosus
Copy link

Hey @adamraine,

Thank you. Valuable info. We'll leave Expect-CT off our header.

It looks like many HTTP Header Checkers need to update their code. They're suggesting that Expect-CT should be added to tested website(s).

Example: securityheaders.com

Details: https://prnt.sc/V1EsBAlDosTf

Above is FYI only. Case closed for us.

Again, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some deprecated-APIs should not be penalised
3 participants