Skip to content

misc(lantern-trace-saver): fix request finishTime #14198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 7, 2022
Merged

misc(lantern-trace-saver): fix request finishTime #14198

merged 1 commit into from
Jul 7, 2022

Conversation

brendankenny
Copy link
Contributor

@brendankenny brendankenny commented Jul 7, 2022 •
edited
Loading

Incidental to #14166. finishTime needs to both start at baseTs and to be in seconds.

before
Information about a network request, showing 'Duration 6.31 s (4.7 hrs network transfer + -17010144827 μs resource loading)'

after
Information about a network request, showing 'Duration 6.31 s (6.31 s network transfer + 0 resource loading)'

@brendankenny brendankenny requested a review from a team as a code owner July 7, 2022 21:00
@brendankenny brendankenny requested review from adamraine and removed request for a team July 7, 2022 21:00
@devtools-bot devtools-bot merged commit 2e57593 into master Jul 7, 2022
@devtools-bot devtools-bot deleted the lantern-trace-saver-fix branch July 7, 2022 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamraine adamraine adamraine approved these changes

Assignees

@adamraine adamraine

Labels
waiting4reviewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brendankenny @adamraine @devtools-bot